hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-08 10:34:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

expose expire_on_commit option

Browse Source 
conservative deployments may set

    c.JupyterHub.db_kwargs['expire_on_commit'] = True

as an escape if the optimization is causing problems.
This commit is contained in:
Min RK
2018-04-20 16:02:29 +02:00
parent e6c2afc4db
commit a021f910c8
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
jupyterhub/orm.py
View File

@@ -621,7 +621,10 @@ def check_db_revision(engine):
)) ))
def new_session_factory(url="sqlite:///:memory:", reset=False, **kwargs): def new_session_factory(url="sqlite:///:memory:",
reset=False,
expire_on_commit=False,
**kwargs):
"""Create a new session at url""" """Create a new session at url"""
if url.startswith('sqlite'): if url.startswith('sqlite'):
kwargs.setdefault('connect_args', {'check_same_thread': False}) kwargs.setdefault('connect_args', {'check_same_thread': False})
@@ -648,5 +651,7 @@ def new_session_factory(url="sqlite:///:memory:", reset=False, **kwargs):
# SQLAlchemy to expire objects after commiting - we don't expect # SQLAlchemy to expire objects after commiting - we don't expect
# concurrent runs of the hub talking to the same db. Turning # concurrent runs of the hub talking to the same db. Turning
# this off gives us a major performance boost # this off gives us a major performance boost
session_factory = sessionmaker(bind=engine, expire_on_commit=False) session_factory = sessionmaker(bind=engine,
expire_on_commit=expire_on_commit,
)
return session_factory return session_factory