From a6f1f6ea095af7cf859f6d4971392acfc44eb977 Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 6 Jun 2017 15:27:56 +0200 Subject: [PATCH] disconnect logging during MockHub cleanup pytest appears to close captured FDs prematurely, causing huge "I/O operation on closed file" tracebacks whenever tests stop early due to a failure. This should quiet the extra traceback, though it could potentially silence useful log messages during cleanup in rare cases --- jupyterhub/tests/conftest.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/jupyterhub/tests/conftest.py b/jupyterhub/tests/conftest.py index 66377426..2263eebb 100644 --- a/jupyterhub/tests/conftest.py +++ b/jupyterhub/tests/conftest.py @@ -53,6 +53,9 @@ def app(request): def fin(): + # disconnect logging during cleanup because pytest closes captured FDs prematurely + mocked_app.log.handlers = [] + MockHub.clear_instance() mocked_app.stop() request.addfinalizer(fin)