hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-17 15:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Test explicitly escaped servername from client

Browse Source
This commit is contained in:
Simon Li
2022-05-24 17:08:21 +01:00
parent 98540f0f6d
commit aa8c85f404
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
jupyterhub/tests/test_named_servers.py
View File

@@ -7,7 +7,7 @@ from urllib.parse import unquote, urlencode, urlparse
import pytest import pytest
from tornado.httputil import url_concat from tornado.httputil import url_concat
from ..utils import url_path_join from ..utils import url_escape_path, url_path_join
from .mocking import FormSpawner, public_url from .mocking import FormSpawner, public_url
from .test_api import TIMESTAMP, add_user, api_request, fill_user, normalize_user from .test_api import TIMESTAMP, add_user, api_request, fill_user, normalize_user
from .utils import async_requests, get_page from .utils import async_requests, get_page
@@ -84,18 +84,28 @@ async def test_default_server(app, named_servers):
@pytest.mark.parametrize( @pytest.mark.parametrize(
'servername,escapedname', 'servername,escapedname,caller_escape',
[ [
('trevor', 'trevor'), ('trevor', 'trevor', False),
('$p~c|a! ch@rs', '%24p~c%7Ca%21%20ch@rs'), ('$p~c|a! ch@rs', '%24p~c%7Ca%21%20ch@rs', False),
('$p~c|a! ch@rs', '%24p~c%7Ca%21%20ch@rs', True),
('must/be/escaped', 'must%2Fbe%2Fescaped', True),
], ],
) )
async def test_create_named_server(app, named_servers, servername, escapedname): async def test_create_named_server(
app, named_servers, servername, escapedname, caller_escape
):
username = 'walnut' username = 'walnut'
user = add_user(app.db, app, name=username) user = add_user(app.db, app, name=username)
# assert user.allow_named_servers == True # assert user.allow_named_servers == True
cookies = await app.login_user(username) cookies = await app.login_user(username)
r = await api_request(app, 'users', username, 'servers', servername, method='post') request_servername = servername
if caller_escape:
request_servername = url_escape_path(servername)
r = await api_request(
app, 'users', username, 'servers', request_servername, method='post'
)
r.raise_for_status() r.raise_for_status()
assert r.status_code == 201 assert r.status_code == 201
assert r.text == '' assert r.text == ''