Use log.exception when logging exceptions

This provides the stack trace in the log file, incredibly
useful when debugging
This commit is contained in:
YuviPanda
2022-05-02 17:36:31 -07:00
parent 107dc02fd0
commit aba6eb962f

View File

@@ -799,7 +799,7 @@ class User:
e.reason = 'timeout' e.reason = 'timeout'
self.settings['statsd'].incr('spawner.failure.timeout') self.settings['statsd'].incr('spawner.failure.timeout')
else: else:
self.log.error( self.log.exception(
"Unhandled error starting {user}'s server: {error}".format( "Unhandled error starting {user}'s server: {error}".format(
user=self.name, error=e user=self.name, error=e
) )
@@ -809,7 +809,7 @@ class User:
try: try:
await self.stop(spawner.name) await self.stop(spawner.name)
except Exception: except Exception:
self.log.error( self.log.exception(
"Failed to cleanup {user}'s server that failed to start".format( "Failed to cleanup {user}'s server that failed to start".format(
user=self.name user=self.name
), ),
@@ -857,7 +857,7 @@ class User:
self.settings['statsd'].incr('spawner.failure.http_timeout') self.settings['statsd'].incr('spawner.failure.http_timeout')
else: else:
e.reason = 'error' e.reason = 'error'
self.log.error( self.log.exception(
"Unhandled error waiting for {user}'s server to show up at {url}: {error}".format( "Unhandled error waiting for {user}'s server to show up at {url}: {error}".format(
user=self.name, url=server.url, error=e user=self.name, url=server.url, error=e
) )
@@ -866,7 +866,7 @@ class User:
try: try:
await self.stop(spawner.name) await self.stop(spawner.name)
except Exception: except Exception:
self.log.error( self.log.exception(
"Failed to cleanup {user}'s server that failed to start".format( "Failed to cleanup {user}'s server that failed to start".format(
user=self.name user=self.name
), ),