From acd75d85c70ee961499bc2ed129fb19c607b20c3 Mon Sep 17 00:00:00 2001
From: Simon Li <orpheus+devel@gmail.com>
Date: Wed, 1 Jun 2022 20:44:40 +0100
Subject: [PATCH] Move installed data file check to script

---
 .github/workflows/release.yml | 22 +++-------------------
 ci/check_installed_data.py    | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 19 deletions(-)
 create mode 100755 ci/check_installed_data.py

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 1df3dcae..264aaea1 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -57,26 +57,10 @@ jobs:
         run: |
           ./ci/check_sdist.py dist/jupyterhub-*.tar.gz
 
-      - name: verify wheel
+      - name: verify data-files are installed where they are found
         run: |
-          cd dist
-          pip install ./*.whl
-          # verify data-files are installed where they are found
-          cat <<EOF | python
-          import os
-          from jupyterhub._data import DATA_FILES_PATH
-          print(f"DATA_FILES_PATH={DATA_FILES_PATH}")
-          assert os.path.exists(DATA_FILES_PATH), DATA_FILES_PATH
-          for subpath in (
-              "templates/page.html",
-              "static/css/style.min.css",
-              "static/components/jquery/dist/jquery.js",
-              "static/js/admin-react.js",
-          ):
-              path = os.path.join(DATA_FILES_PATH, subpath)
-              assert os.path.exists(path), path
-          print("OK")
-          EOF
+          pip install dist/*.whl
+          ./ci/check_installed_data.py
 
       # ref: https://github.com/actions/upload-artifact#readme
       - uses: actions/upload-artifact@v2
diff --git a/ci/check_installed_data.py b/ci/check_installed_data.py
new file mode 100755
index 00000000..726c0408
--- /dev/null
+++ b/ci/check_installed_data.py
@@ -0,0 +1,20 @@
+#!/usr/bin/env python
+# Check that installed package contains everything we expect
+
+
+import os
+
+from jupyterhub._data import DATA_FILES_PATH
+
+print("Checking jupyterhub._data")
+print(f"DATA_FILES_PATH={DATA_FILES_PATH}")
+assert os.path.exists(DATA_FILES_PATH), DATA_FILES_PATH
+for subpath in (
+    "templates/page.html",
+    "static/css/style.min.css",
+    "static/components/jquery/dist/jquery.js",
+    "static/js/admin-react.js",
+):
+    path = os.path.join(DATA_FILES_PATH, subpath)
+    assert os.path.exists(path), path
+print("OK")