From ad2abc57716085d5469e8cfaabf5de573ffa79f0 Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 22 May 2018 09:55:01 +0200 Subject: [PATCH] default bind url should be on all ips preserves jupyterhub default behavior typo introduced in new bind_url config --- jupyterhub/app.py | 2 +- jupyterhub/tests/test_app.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/jupyterhub/app.py b/jupyterhub/app.py index 84973e08..667f5e93 100644 --- a/jupyterhub/app.py +++ b/jupyterhub/app.py @@ -358,7 +358,7 @@ class JupyterHub(Application): self.bind_url = bind_url bind_url = Unicode( - "http://127.0.0.1:8000", + "http://:8000", help="""The public facing URL of the whole JupyterHub application. This is the address on which the proxy will bind. diff --git a/jupyterhub/tests/test_app.py b/jupyterhub/tests/test_app.py index d18adde4..1a220219 100644 --- a/jupyterhub/tests/test_app.py +++ b/jupyterhub/tests/test_app.py @@ -242,6 +242,16 @@ def test_resume_spawners(tmpdir, request): {'bind_url': 'http://0.0.0.0:12345/sub'}, {'base_url': '/sub/'}, ), + ( + # no config, test defaults + {}, + { + 'base_url': '/', + 'bind_url': 'http://:8000', + 'ip': '', + 'port': 8000, + }, + ), ] ) def test_url_config(hub_config, expected):