hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-12 04:23:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove old comment, include description in servername error

Browse Source 
Co-authored-by: Min RK <benjaminrk@gmail.com>
This commit is contained in:
Simon Li
2022-06-01 21:28:24 +01:00
committed by GitHub
parent 7b8a2ae57b
commit b403c41c15
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
jupyterhub/handlers/base.py
View File

@@ -856,7 +856,7 @@ class BaseHandler(RequestHandler):
if server_name: if server_name:
if '/' in server_name: if '/' in server_name:
error_message = f"Invalid server_name: {server_name}" error_message = f"Invalid server_name (may not contain '/'): {server_name}"
self.log.error(error_message) self.log.error(error_message)
raise web.HTTPError(400, error_message) raise web.HTTPError(400, error_message)
user_server_name = f'{user.name}:{server_name}' user_server_name = f'{user.name}:{server_name}'

1
jupyterhub/user.py
View File

@@ -687,7 +687,6 @@ class User:
client_id, client_id,
api_token, api_token,
url_path_join(self.url, url_escape_path(server_name), 'oauth_callback'), url_path_join(self.url, url_escape_path(server_name), 'oauth_callback'),
# url_path_join(self.url, server_name, 'oauth_callback'),
allowed_roles=allowed_roles, allowed_roles=allowed_roles,
description="Server at %s" description="Server at %s"
% (url_path_join(self.base_url, server_name) + '/'), % (url_path_join(self.base_url, server_name) + '/'),