hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-19 07:53:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

register cleanup before start

Browse Source 
avoids leaving lingering proxy if app fails to start
This commit is contained in:
Min RK
2018-10-15 15:33:59 +02:00
parent 28c6377db7
commit b72d887dd7
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
jupyterhub/tests/conftest.py
View File

@@ -71,12 +71,10 @@ def app(request, io_loop, ssl_tmpdir):
else: else:
mocked_app = MockHub.instance(log_level=logging.DEBUG) mocked_app = MockHub.instance(log_level=logging.DEBUG)
@gen.coroutine
def make_app():
yield mocked_app.initialize([])
yield mocked_app.start()
io_loop.run_sync(make_app) async def make_app():
await mocked_app.initialize([])
await mocked_app.start()
def fin(): def fin():
# disconnect logging during cleanup because pytest closes captured FDs prematurely # disconnect logging during cleanup because pytest closes captured FDs prematurely
@@ -85,6 +83,7 @@ def app(request, io_loop, ssl_tmpdir):
mocked_app.stop() mocked_app.stop()
request.addfinalizer(fin) request.addfinalizer(fin)
io_loop.run_sync(make_app)
return mocked_app return mocked_app