From aed99d8d19714e2d94e6501dd79498c5e2fd2128 Mon Sep 17 00:00:00 2001 From: Carol Willing Date: Thu, 14 Jun 2018 13:24:05 -0700 Subject: [PATCH 1/2] add test case for user with tilde --- jupyterhub/tests/test_proxy.py | 1 + 1 file changed, 1 insertion(+) diff --git a/jupyterhub/tests/test_proxy.py b/jupyterhub/tests/test_proxy.py index e8cbfa92..ddb614cd 100644 --- a/jupyterhub/tests/test_proxy.py +++ b/jupyterhub/tests/test_proxy.py @@ -154,6 +154,7 @@ def test_external_proxy(request): 'zoe', '50fia', '秀樹', + '~TestJH' ]) def test_check_routes(app, username, disable_check_routes): proxy = app.proxy From bb81ce0160640f6682278e1942700bbdcdf5ac91 Mon Sep 17 00:00:00 2001 From: Min RK Date: Fri, 15 Jun 2018 14:33:31 +0200 Subject: [PATCH 2/2] also test @ handling in proxy.check_routes @ and ~ should be the same --- jupyterhub/tests/test_proxy.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jupyterhub/tests/test_proxy.py b/jupyterhub/tests/test_proxy.py index ddb614cd..1c0cf12d 100644 --- a/jupyterhub/tests/test_proxy.py +++ b/jupyterhub/tests/test_proxy.py @@ -154,7 +154,8 @@ def test_external_proxy(request): 'zoe', '50fia', '秀樹', - '~TestJH' + '~TestJH', + 'has@', ]) def test_check_routes(app, username, disable_check_routes): proxy = app.proxy