hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-16 06:22:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make rollback conditional on db.dirty

Browse Source 
avoids calling rollback when there are no changes

includes warning about what objects are actually dirty
This commit is contained in:
Min RK
2017-07-24 12:53:58 +02:00
parent 1229fd100f
commit ce53b11cf7
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
jupyterhub/handlers/base.py
View File

@@ -94,7 +94,9 @@ class BaseHandler(RequestHandler):
def finish(self, *args, **kwargs): def finish(self, *args, **kwargs):
"""Roll back any uncommitted transactions from the handler.""" """Roll back any uncommitted transactions from the handler."""
self.db.rollback() if self.db.dirty:
self.log.warning("Rolling back dirty objects %s", self.db.dirty)
self.db.rollback()
super().finish(*args, **kwargs) super().finish(*args, **kwargs)
#--------------------------------------------------------------- #---------------------------------------------------------------