From d0120ef56c0ec11c60a87d719cd24567a024ff3c Mon Sep 17 00:00:00 2001 From: Min RK Date: Mon, 24 Mar 2025 13:11:33 +0100 Subject: [PATCH] don't keep waiting for log messages after we've received what we expect avoids potential race waiting for an element on he progress page after navigating away --- jupyterhub/tests/browser/test_browser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jupyterhub/tests/browser/test_browser.py b/jupyterhub/tests/browser/test_browser.py index f604f5cc..d954597a 100644 --- a/jupyterhub/tests/browser/test_browser.py +++ b/jupyterhub/tests/browser/test_browser.py @@ -291,7 +291,8 @@ async def test_spawn_pending_progress( "Spawning server...", f"Server ready at {app.base_url}user/{urlname}/", ] - while not user.spawner.ready: + logs_list = [] + while not user.spawner.ready and len(logs_list) < len(expected_messages): logs_list = [ await log.text_content() for log in await browser.locator("div.progress-log-event").all()