hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-13 04:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #490 from minrk/disable-pam-session

Browse Source 
Allow disabling PAM sessions
This commit is contained in:
Carol Willing
2016-03-24 07:57:00 -07:00
parent 28c8265c3d 40368b8f55
commit dd3ed1bf75
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
jupyterhub/auth.py
View File

@@ -357,6 +357,18 @@ class PAMAuthenticator(LocalAuthenticator):
service = Unicode('login', config=True, service = Unicode('login', config=True,
help="""The PAM service to use for authentication.""" help="""The PAM service to use for authentication."""
) )
open_sessions = Bool(True, config=True,
help="""Whether to open PAM sessions when spawners are started.
This may trigger things like mounting shared filsystems,
loading credentials, etc. depending on system configuration,
but it does not always work.
It can be disabled with::
c.PAMAuthenticator.open_sessions = False
"""
)
@gen.coroutine @gen.coroutine
def authenticate(self, handler, data): def authenticate(self, handler, data):
@@ -369,7 +381,7 @@ class PAMAuthenticator(LocalAuthenticator):
pamela.authenticate(username, data['password'], service=self.service) pamela.authenticate(username, data['password'], service=self.service)
except pamela.PAMError as e: except pamela.PAMError as e:
if handler is not None: if handler is not None:
self.log.warn("PAM Authentication failed (@%s): %s", handler.request.remote_ip, e) self.log.warn("PAM Authentication failed (%s@%s): %s", username, handler.request.remote_ip, e)
else: else:
self.log.warn("PAM Authentication failed: %s", e) self.log.warn("PAM Authentication failed: %s", e)
else: else:
@@ -377,15 +389,23 @@ class PAMAuthenticator(LocalAuthenticator):
def pre_spawn_start(self, user, spawner): def pre_spawn_start(self, user, spawner):
"""Open PAM session for user""" """Open PAM session for user"""
if not self.open_sessions:
return
try: try:
pamela.open_session(user.name, service=self.service) pamela.open_session(user.name, service=self.service)
except pamela.PAMError as e: except pamela.PAMError as e:
self.log.warn("Failed to open PAM session for %s: %s", user.name, e) self.log.warn("Failed to open PAM session for %s: %s", user.name, e)
self.log.warn("Disabling PAM sessions from now on.")
self.open_sessions = False
def post_spawn_stop(self, user, spawner): def post_spawn_stop(self, user, spawner):
"""Close PAM session for user""" """Close PAM session for user"""
if not self.open_sessions:
return
try: try:
pamela.close_session(user.name, service=self.service) pamela.close_session(user.name, service=self.service)
except pamela.PAMError as e: except pamela.PAMError as e:
self.log.warn("Failed to close PAM session for %s: %s", user.name, e) self.log.warn("Failed to close PAM session for %s: %s", user.name, e)
self.log.warn("Disabling PAM sessions from now on.")
self.open_sessions = False