hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-15 14:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use encoded URL when redirecting user notebooks

Browse Source 
Otherwise it breaks for usernames that have url unsafe
characters.
This commit is contained in:
YuviPanda
2016-03-08 17:08:23 -08:00
parent f7dab558e4
commit e0219d0363
3 changed files with 53 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
jupyterhub/handlers/pages.py
View File

@@ -8,7 +8,7 @@ from tornado import web, gen
from .. import orm from .. import orm
from ..utils import admin_only, url_path_join from ..utils import admin_only, url_path_join
from .base import BaseHandler from .base import BaseHandler
from .login import LoginHandler from urllib.parse import quote
class RootHandler(BaseHandler): class RootHandler(BaseHandler):
@@ -75,7 +75,9 @@ class SpawnHandler(BaseHandler):
self.finish(self._render_form()) self.finish(self._render_form())
else: else:
# not running, no form. Trigger spawn. # not running, no form. Trigger spawn.
url = url_path_join(self.base_url, 'user', user.name) # Creating the URL manually since the server does not
# exist yet
url = url_path_join(self.base_url, 'user', quote(user.name))
self.redirect(url) self.redirect(url)
@web.authenticated @web.authenticated

2
share/jupyter/hub/templates/home.html
View File

@@ -10,7 +10,7 @@
{% endif %} {% endif %}
<a id="start" class="btn btn-lg btn-success" <a id="start" class="btn btn-lg btn-success"
{% if user.running %} {% if user.running %}
href="{{base_url}}user/{{user.name}}/" href="{{ user.server.base_url }}"
{% else %} {% else %}
href="{{base_url}}spawn" href="{{base_url}}spawn"
{% endif %} {% endif %}