hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-18 07:23:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't delete failed spawners

Browse Source 
They preserve error messages that are useful

only delete spawners that shutdown cleanly
This commit is contained in:
Min RK
2018-04-09 11:38:29 +02:00
parent c0f37c48a1
commit e56d416210
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
jupyterhub/user.py
View File

@@ -554,5 +554,7 @@ class User:
except Exception: except Exception:
self.log.exception("Error in Authenticator.post_spawn_stop for %s", self) self.log.exception("Error in Authenticator.post_spawn_stop for %s", self)
spawner._stop_pending = False spawner._stop_pending = False
# pop the Spawner object if not (spawner._spawn_future and spawner._spawn_future.exception()):
self.spawners.pop(server_name) # pop Spawner *unless* it's stopping due to an error
# because some pages serve latest-spawn error messages
self.spawners.pop(server_name)