From e75dd1b79c5d1e21278a59a5b98eeb45ae2b53e8 Mon Sep 17 00:00:00 2001 From: Min RK Date: Thu, 11 Mar 2021 15:49:35 +0100 Subject: [PATCH] Stop specifying `--ip` and `--port` on the command-line JUPYTERHUB_SERVICE_URL env is already enough and has been around for some time Specifying CLI args can cause some issues for custom entrypoints --- jupyterhub/spawner.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/jupyterhub/spawner.py b/jupyterhub/spawner.py index dc335d47..cd9bcced 100644 --- a/jupyterhub/spawner.py +++ b/jupyterhub/spawner.py @@ -999,17 +999,6 @@ class Spawner(LoggingConfigurable): """ args = [] - if self.ip: - args.append('--ip=%s' % _quote_safe(self.ip)) - - if self.port: - args.append('--port=%i' % self.port) - elif self.server and self.server.port: - self.log.warning( - "Setting port from user.server is deprecated as of JupyterHub 0.7." - ) - args.append('--port=%i' % self.server.port) - if self.notebook_dir: notebook_dir = self.format_string(self.notebook_dir) args.append('--notebook-dir=%s' % _quote_safe(notebook_dir))