hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-07 10:04:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

examples/service-whoami-flask: Fix return types in oauth_callback

Browse Source 
In my testing, Flask 3.0.0 doesn't accept returning only an integer
(as an error code) in a handler.  A (content, status) tuple does
work.  I don't know if this is a recent change, or if this has always
been broken, but the tuple return should be good for older Flask
versions as well.
This commit is contained in:
Robert Schroll
2024-01-18 15:18:26 -08:00
parent 8a5fc8044a
commit e879ab18e2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
examples/service-whoami-flask/whoami-flask.py
View File

@@ -56,14 +56,14 @@ def whoami(user):
def oauth_callback(): def oauth_callback():
code = request.args.get('code', None) code = request.args.get('code', None)
if code is None: if code is None:
return 403 return "Forbidden", 403
# validate state field # validate state field
arg_state = request.args.get('state', None) arg_state = request.args.get('state', None)
cookie_state = request.cookies.get(auth.state_cookie_name) cookie_state = request.cookies.get(auth.state_cookie_name)
if arg_state is None or arg_state != cookie_state: if arg_state is None or arg_state != cookie_state:
# state doesn't match # state doesn't match
return 403 return "Forbidden", 403
token = auth.token_for_code(code) token = auth.token_for_code(code)
# store token in session cookie # store token in session cookie