hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-14 21:43:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

log errors adding users already in db

Browse Source 
avoids removal of system users preventing Hub startup
This commit is contained in:
Min RK
2016-08-15 14:06:38 +02:00
parent 4edf59efeb
commit eda21642bd
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
jupyterhub/app.py
View File

@@ -855,7 +855,13 @@ class JupyterHub(Application):
# but changes to the whitelist can occur in the database, # but changes to the whitelist can occur in the database,
# and persist across sessions. # and persist across sessions.
for user in db.query(orm.User): for user in db.query(orm.User):
yield gen.maybe_future(self.authenticator.add_user(user)) try:
yield gen.maybe_future(self.authenticator.add_user(user))
except Exception:
# TODO: Review approach to synchronize whitelist with db
# known cause of the exception is a user who has already been removed from the system
# but the user still exists in the hub's user db
self.log.exception("Error adding user %r already in db", user.name)
db.commit() # can add_user touch the db? db.commit() # can add_user touch the db?
# The whitelist set and the users in the db are now the same. # The whitelist set and the users in the db are now the same.