Fix issue probably-meant-fstring found at https://codereview.doctor

This commit is contained in:
code-review-doctor
2022-04-24 17:30:49 +01:00
parent a588a0bfa3
commit f0b2d8c4eb
5 changed files with 6 additions and 6 deletions

View File

@@ -49,7 +49,7 @@ class GroupListAPIHandler(_GroupAPIHandler):
# the only valid filter is group=... # the only valid filter is group=...
# don't expand invalid !server=x to all groups! # don't expand invalid !server=x to all groups!
self.log.warning( self.log.warning(
"Invalid filter on list:group for {self.current_user}: {sub_scope}" f"Invalid filter on list:group for {self.current_user}: {sub_scope}"
) )
raise web.HTTPError(403) raise web.HTTPError(403)
query = query.filter(orm.Group.name.in_(sub_scope['group'])) query = query.filter(orm.Group.name.in_(sub_scope['group']))

View File

@@ -124,7 +124,7 @@ class UserListAPIHandler(APIHandler):
if not set(sub_scope).issubset({'group', 'user'}): if not set(sub_scope).issubset({'group', 'user'}):
# don't expand invalid !server=x filter to all users! # don't expand invalid !server=x filter to all users!
self.log.warning( self.log.warning(
"Invalid filter on list:user for {self.current_user}: {sub_scope}" f"Invalid filter on list:user for {self.current_user}: {sub_scope}"
) )
raise web.HTTPError(403) raise web.HTTPError(403)
filters = [] filters = []

View File

@@ -496,7 +496,7 @@ class TokenPageHandler(BaseHandler):
continue continue
if not token.client_id: if not token.client_id:
# token should have been deleted when client was deleted # token should have been deleted when client was deleted
self.log.warning("Deleting stale oauth token {token}") self.log.warning(f"Deleting stale oauth token {token}")
self.db.delete(token) self.db.delete(token)
self.db.commit() self.db.commit()
continue continue

View File

@@ -230,7 +230,7 @@ class Spawner(LoggingConfigurable):
self.orm_spawner.server = server.orm_server self.orm_spawner.server = server.orm_server
elif server is not None: elif server is not None:
self.log.warning( self.log.warning(
"Setting Spawner.server for {self._log_name} with no underlying orm_spawner" f"Setting Spawner.server for {self._log_name} with no underlying orm_spawner"
) )
@property @property

View File

@@ -269,9 +269,9 @@ class User:
new_groups = set(group_names).difference(current_groups) new_groups = set(group_names).difference(current_groups)
removed_groups = current_groups.difference(group_names) removed_groups = current_groups.difference(group_names)
if new_groups: if new_groups:
self.log.info("Adding user {self.name} to group(s): {new_groups}") self.log.info(f"Adding user {self.name} to group(s): {new_groups}")
if removed_groups: if removed_groups:
self.log.info("Removing user {self.name} from group(s): {removed_groups}") self.log.info(f"Removing user {self.name} from group(s): {removed_groups}")
if group_names: if group_names:
groups = ( groups = (