From a0042e9302e5aeaafc9d59a2c25845a59c12d3c3 Mon Sep 17 00:00:00 2001 From: Min RK Date: Wed, 27 Sep 2017 14:29:56 +0200 Subject: [PATCH] typo rendering logout page when auto_login=True and include it in test coverage --- jupyterhub/handlers/login.py | 2 +- jupyterhub/tests/test_pages.py | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/jupyterhub/handlers/login.py b/jupyterhub/handlers/login.py index 2f934e79..537ff5b2 100644 --- a/jupyterhub/handlers/login.py +++ b/jupyterhub/handlers/login.py @@ -20,7 +20,7 @@ class LogoutHandler(BaseHandler): self.clear_login_cookie() self.statsd.incr('logout') if self.authenticator.auto_login: - self.render('logout.html') + self.render_template('logout.html') else: self.redirect(self.settings['login_url'], permanent=False) diff --git a/jupyterhub/tests/test_pages.py b/jupyterhub/tests/test_pages.py index 8248ff12..eb7dc866 100644 --- a/jupyterhub/tests/test_pages.py +++ b/jupyterhub/tests/test_pages.py @@ -344,6 +344,19 @@ def test_auto_login(app, request): r = yield async_requests.get(base_url) assert r.url == public_url(app, path='hub/dummy') +@pytest.mark.gen_test +def test_auto_login_logout(app): + name = 'burnham' + cookies = yield app.login_user(name) + + with mock.patch.dict(app.tornado_application.settings, { + 'authenticator': Authenticator(auto_login=True), + }): + r = yield async_requests.get(public_host(app) + app.tornado_settings['logout_url'], cookies=cookies) + r.raise_for_status() + logout_url = public_host(app) + app.tornado_settings['logout_url'] + assert r.url == logout_url + assert r.cookies == {} @pytest.mark.gen_test def test_logout(app):