hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-07 10:04:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Align test variables' naming with tested function's terminology

Browse Source
This commit is contained in:
Erik Sundell
2022-10-08 16:59:56 +02:00
parent 7585026f81
commit fd5705b74b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
jupyterhub/tests/test_scopes.py
View File

@@ -1211,7 +1211,7 @@ def test_expand_scopes(app, user, scopes, expected, mockservice_external):
@pytest.mark.parametrize( @pytest.mark.parametrize(
"requested_scopes, have_scopes, expected_allowed, expected_excluded", "requested_scopes, have_scopes, expected_allowed, expected_disallowed",
[ [
( (
["read:users:name!user"], ["read:users:name!user"],
@@ -1252,7 +1252,7 @@ def test_resolve_requested_scopes(
requested_scopes, requested_scopes,
have_scopes, have_scopes,
expected_allowed, expected_allowed,
expected_excluded, expected_disallowed,
mockservice_external, mockservice_external,
): ):
if isinstance(requested_scopes, str): if isinstance(requested_scopes, str):
@@ -1282,9 +1282,9 @@ def test_resolve_requested_scopes(
requested_scopes = format_scopes(requested_scopes) requested_scopes = format_scopes(requested_scopes)
have_scopes = format_scopes(have_scopes) have_scopes = format_scopes(have_scopes)
expected_allowed = format_scopes(expected_allowed) expected_allowed = format_scopes(expected_allowed)
expected_excluded = format_scopes(expected_excluded) expected_disallowed = format_scopes(expected_disallowed)
allowed, excluded = _resolve_requested_scopes( allowed, disallowed = _resolve_requested_scopes(
requested_scopes, requested_scopes,
have_scopes, have_scopes,
user=user.orm_user, user=user.orm_user,
@@ -1292,4 +1292,4 @@ def test_resolve_requested_scopes(
db=db, db=db,
) )
assert allowed == expected_allowed assert allowed == expected_allowed
assert excluded == expected_excluded assert disallowed == expected_disallowed