From 210975324a5fd94a0365b499365af8e941fda06c Mon Sep 17 00:00:00 2001 From: Min RK Date: Wed, 30 Aug 2017 11:31:44 +0200 Subject: [PATCH] fix logging error when login_user is called with no form data and login fails --- jupyterhub/handlers/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jupyterhub/handlers/base.py b/jupyterhub/handlers/base.py index f46befc4..a9575ee0 100644 --- a/jupyterhub/handlers/base.py +++ b/jupyterhub/handlers/base.py @@ -347,7 +347,7 @@ class BaseHandler(RequestHandler): else: self.statsd.incr('login.failure') self.statsd.timing('login.authenticate.failure', auth_timer.ms) - self.log.warning("Failed login for %s", data.get('username', 'unknown user')) + self.log.warning("Failed login for %s", (data or {}).get('username', 'unknown user')) #---------------------------------------------------------------