hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-13 04:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed removals caused by merge, documentation

Browse Source
This commit is contained in:
vpopescu
2023-01-11 10:42:03 +01:00
parent e84359cc23
commit fec0cb1260
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
jsx/src/components/GroupEdit/GroupEdit.jsx
View File

@@ -110,6 +110,7 @@ const GroupEdit = (props) => {
data-testid="submit" data-testid="submit"
className="btn btn-primary" className="btn btn-primary"
onClick={() => { onClick={() => {
// check for changes
let new_users = selected.filter( let new_users = selected.filter(
(e) => !group_data.users.includes(e), (e) => !group_data.users.includes(e),
); );

3
jupyterhub/app.py
View File

@@ -310,6 +310,9 @@ class JupyterHub(Application):
Loading one set of groups, then starting JupyterHub again with a different Loading one set of groups, then starting JupyterHub again with a different
set will not remove users or groups from previous launches. set will not remove users or groups from previous launches.
That must be done through the API. That must be done through the API.
.. versionchanged:: 3.2
Changed format of group from list of usernames to dict
""", """,
).tag(config=True) ).tag(config=True)

2
jupyterhub/tests/test_app.py
View File

@@ -30,7 +30,7 @@ def test_help_all():
assert '--JupyterHub.ip' in out assert '--JupyterHub.ip' in out
@pytest.mark.skipif(V(traitlets.__version__) < V('5'), reason="requires traitlets 5") @pytest.mark.skipif(traitlets.version_info < (5,), reason="requires traitlets 5")
def test_show_config(tmpdir): def test_show_config(tmpdir):
tmpdir.chdir() tmpdir.chdir()
p = Popen( p = Popen(