Erik Sundell
0679586b2c
docs: please docs linter properly
...
We are users of the napoleon sphinx extension, which helps us parse our
Google Style Python Docstrings, and its syntax suggest we should use
indentation when we use more then one string for an entry in an
Arguments: or Returns: list.
For more details, see: https://github.com/jupyterhub/jupyterhub/pull/3151#issuecomment-676186565
2020-08-19 13:49:28 +02:00
Erik Sundell
be4201f7ee
docs: please docs linter (move_cert docstring)
2020-08-19 13:14:46 +02:00
Min RK
11a73b5630
Merge pull request #3131 from rkevin-arch/healthcheck-head-request
...
Allow head requests for the health endpoint
2020-08-18 10:57:09 +02:00
Tim Head
f1efac41bf
Merge pull request #3143 from basvandervlies/apache_reverse_proxy_doc
...
Needed NoEsacpe (NE) option for apache
2020-08-14 14:54:23 +02:00
Bas van der Vlies
aa6921dd5a
Needed NoEsacpe (NE) option for apache
...
Else %20 is esacped to %25%20 and we acan not rename "Untitled Folder'
or opening files with spaces or other special chars fails.
2020-08-14 11:24:27 +02:00
Seth Nickell
e94da17c3c
Document external service api_tokens better
...
- Explicitly mention min-8-char constraint
- Connect the api_token in the configuration with the one mentioned in auth requests
Co-authored-by: Mike Situ <msitu@ceresimaging.net >
2020-08-13 12:28:17 -10:00
Min RK
e2ee18fa86
Merge pull request #3123 from alexweav/tornado-py38
...
app.py: Work around incompatibility between Tornado 6 and asyncio proactor event loop in python 3.8 on Windows
2020-08-10 09:18:24 +02:00
Lydian Lee
c5ec8ceba3
admin page sorts on spawner last_activity instead of user last_activity
2020-08-07 16:37:47 -07:00
pabepadu
3458c742cb
Add a footer block + wrap the admin footer in this block
2020-08-07 02:19:21 +02:00
Georgiana Elena
d1a85e53dc
Merge pull request #3132 from pabepadu/fix_services_dropdown_in_admin_page
...
Fix the services dropdown on the admin page
2020-08-07 00:13:37 +03:00
Dan Lester
d915cc3ff2
Allow JupyterHub.default_url to be a callable based on user
2020-08-05 11:59:25 +01:00
Georgiana Elena
b11c02c6e0
Merge pull request #3118 from minrk/tag-from-singleuser
...
only build tagged versions on docker tags
2020-08-05 12:44:23 +03:00
pabepadu
49f3bb53f4
Fix the services dropdown in the admin page
2020-08-05 05:29:21 +02:00
rkevin
9b7a94046b
Allow head requests for the health endpoint
2020-08-03 00:20:17 -07:00
Min RK
62ef5ca2fe
test with /api/spec.yaml
...
because /api/status is currently broken in jupyter_server
2020-07-31 12:44:42 +02:00
Min RK
028e0b0b77
include JUPYTERHUB_SINGLEUSER_APP in env_keep
...
since the child process is the one that inherits it anyway
2020-07-31 12:12:38 +02:00
Min RK
d2a42a69b0
simplify app mixin
...
get handler classes from instance attributes, rather than arguments
simplifies API
2020-07-31 12:12:11 +02:00
Min RK
1f21f283df
Merge pull request #3127 from mriedem/3126-slow-spawn-timeout-warning
...
Don't log a warning when slow_spawn_timeout is disabled
2020-07-31 12:07:38 +02:00
Alex Weaver
7f35158575
Also apply patch before creating new event loop in atexit, just in case
2020-07-29 11:03:05 -05:00
Min RK
d0da677813
infer default mixins from $JUPYTERHUB_SINGLEUSER_APP
...
set to e.g. JUPYTERHUB_SINGLEUSER_APP=jupyterlab.labapp.LabApp for JupyterLab
2020-07-24 13:06:35 +02:00
Min RK
a0a02688c5
create singleuser app with mixins
...
for easier reuse with jupyter_server
mixins have a lot of assumptions about the NotebookApp structure.
Need to make sure these are met by jupyter_server (that's what tests are for!)
2020-07-24 12:57:05 +02:00
Min RK
2372842b8a
Merge remote-tracking branch 'origin/master' into mix-it-in
...
# Conflicts:
# .travis.yml
2020-07-24 09:53:02 +02:00
Matt Riedemann
7e205a9751
Don't log a warning when slow_spawn_timeout is disabled
...
When using the `KubeSpawner` it is typical to disable the
`slow_spawn_timeout` by setting it to 0. `zero-to-jupyterhub-k8s`
does this by default [1]. However, this causes an immediate `TimeoutError`
which gets logged as a warning like this:
>User hub-stress-test-123 is slow to start (timeout=0)
This avoids the warning by checking the value and if disabled simply
returns without logging the warning.
[1] https://github.com/jupyterhub/zero-to-jupyterhub-k8s/commit/b4738edc5
Closes #3126
2020-07-23 16:09:19 -05:00
Alex Weaver
e7fab5c304
Format and lint
2020-07-22 15:16:11 -05:00
Alex Weaver
8b8b512d06
Apply asyncio patch
2020-07-22 15:04:16 -05:00
Richard Darst
714072dbd8
jupyterhub/user: clear spawner state after post_stop_hook
...
- Related issue: #3120 . Closes : #3120 .
- I realized that spawner.clear_state() is called before
spawner.post_stop_hook(). This caused was a bit surprising to me,
and caused some issues.
- I tried the naive strategy of moving clear_state to later and
setting the orm_state to `{}` at the point where it used to be
clear.
- This tries to maintain the exception behavior of clear_state and
post_stop_hook, but is exactly identical.
- To review:
- I'm not sure this is a good idea!
- Carefully consider the implications of this. I am not at all sure
about unintended side-effects or what intended semantics are.
2020-07-22 10:06:21 +03:00
Min RK
6e8f39c22d
only build tagged versions on docker tags
...
instead of building 'stable' from master
2020-07-20 10:14:35 +02:00
Erik Sundell
f3c3225124
Merge pull request #3114 from yuvipanda/no-cull-idle
...
Remove idle culler example
2020-07-14 17:03:12 +02:00
Georgiana Elena
614bfe77d8
Update examples/cull-idle/README.md
2020-07-14 14:22:51 +03:00
YuviPanda
1beea06ce5
Remove idle culler example
...
Has been moved to its own repo.
See https://github.com/jupyterhub/the-littlest-jupyterhub/pull/559
for more info
2020-07-12 17:14:14 +05:30
Erik Sundell
42adb44153
Merge pull request #3111 from mriedem/log-slow-stop-timeout
...
Log slow_stop_timeout when hit like slow_spawn_timeout
2020-07-11 02:56:13 +02:00
Matt Riedemann
d5a0202106
Log slow_stop_timeout when hit like slow_spawn_timeout
...
When `slow_spawn_timeout` is hit the configured timeout value
gets logged [1]. This does the same thing when `slow_stop_timeout`
is hit.
[1] https://github.com/jupyterhub/jupyterhub/blob/1.1.0/jupyterhub/handlers/base.py#L947
2020-07-10 11:38:26 -05:00
Georgiana Elena
3d524f2092
Merge pull request #3109 from kxiao-fn/proper_named_server_deletion
...
fix for stopping named server deleting default server and tests
2020-07-07 15:41:43 +03:00
Katherine Xiao
409835303e
formatting
2020-07-06 17:45:08 -07:00
Katherine Xiao
acc8d15fec
fixed test
2020-07-06 17:23:42 -07:00
Katherine Xiao
608cad6404
fix in base.py
2020-07-06 12:53:50 -07:00
Katherine Xiao
571a428375
fix deletion of default server when stopping named server and added corresponding test
2020-07-06 12:48:41 -07:00
Chris Holdgraf
1575adf272
Merge pull request #3107 from consideRatio/docs-logo-rem-unused-stuff
...
docs: unsqueeze logo, remove unused CSS and templates
2020-07-06 08:00:14 -07:00
Erik Sundell
4bc6d869f3
docs: unsqueeze logo, remove unused CSS and templates
2020-07-05 03:12:18 +02:00
Min RK
e5a6119505
Merge pull request #3090 from minrk/words-matter
2020-07-03 12:27:08 +02:00
Félix-Antoine Fortin
d80dab284d
Update version in docs/rest-api.yaml
2020-06-30 08:59:29 -04:00
Bruno P. Kinoshita
9d556728bb
Add padding for the span with user name and logout button (responsive mode only)
2020-06-25 23:31:54 +12:00
Bruno P. Kinoshita
4369e2cbfa
Adjust jupyterhub logo margin-left in responsive mode
2020-06-25 23:31:54 +12:00
Bruno P. Kinoshita
ef4455bb67
Closes #2182 display hamburger menu only if user variable is present (in responsive mode)
2020-06-25 23:31:54 +12:00
Min RK
76c9111d80
Merge pull request #3089 from kinow/redirect-with-parameters
2020-06-25 11:08:17 +02:00
Bruno P. Kinoshita
946ed844c5
Update jupyterhub/handlers/base.py
...
Co-authored-by: Min RK <benjaminrk@gmail.com >
2020-06-25 19:41:46 +12:00
Min RK
cceb652039
TODO is TODONE
...
Co-authored-by: Georgiana Elena <georgiana.dolocan@gmail.com >
2020-06-24 20:19:44 +02:00
Min RK
6e988bf587
call it allowed_users
...
be clearer since it's users vs groups, etc.
2020-06-24 13:29:42 +02:00
Simon Li
dbc6998375
Merge pull request #3102 from minrk/unpin-telemetry
...
loosen jupyter-telemetry pin
2020-06-23 14:18:40 +01:00
Bruno P. Kinoshita
1bdc9aa297
Escape/encode parameters with the next URL, add more tests
2020-06-24 00:18:55 +12:00