Commit Graph

7838 Commits

Author SHA1 Message Date
Min RK
d0523f5e93 Merge pull request #4781 from minrk/template-debug
clarify error template debug log
2024-04-11 09:35:24 +02:00
krassowski
b79cb12095 Polish the documentation 2024-04-10 14:52:23 +01:00
krassowski
b486fc8abe Fix tests after making the default load_managed_roles raise
Four tests were not using a mock authenticator:
- two get `reset_managed_roles_on_startup` toggled
- two get a custom implementation of `load_managed_roles`
2024-04-10 13:41:54 +01:00
krassowski
4d8c3cbf0d Do not load non-existent managed_by_auth column
in `api_token_scopes` migration, which fixes 2.1.1 test
2024-04-10 13:19:30 +01:00
Min RK
6a93abbe1c Merge pull request #4779 from krassowski/support-allow_unauthenticated_access-false
Support forbidding unauthenticated access (`allow_unauthenticated_access = False`)
2024-04-10 13:19:45 +02:00
krassowski
84ed311902 Check for table existence in alembic migration 2024-04-10 12:02:12 +01:00
Min RK
6c0a0643e8 Merge pull request #4776 from minrk/forward-415
forward-port 4.1.5
2024-04-10 12:57:50 +02:00
Min RK
e3ea59759e clarify error template debug log
'No template for 404' looks like something's wrong, when all it means to convey is that it doesn't get _special_ treatment
and the default error page is enough.
2024-04-10 12:56:41 +02:00
krassowski
aefc8de49a Add @allow_unauthenticated decorators 2024-04-10 11:03:33 +01:00
krassowski
88189d54d9 Add a test for allow_unauthenticated_access (xfail) 2024-04-10 10:58:21 +01:00
Min RK
3fe1e9d510 update admin for bs5
- panel became card
- fix alignment of filter checkbox
- make all buttons consistently buttons
2024-04-09 13:48:41 +02:00
Min RK
93a34d9874 testing config: enable named servers
for easier testing of more features
2024-04-09 13:48:41 +02:00
krassowski
f609b00358 Fix docs warnings, add version added admonitions 2024-04-09 11:53:34 +01:00
Min RK
9d835a8670 make sure navbar, named servers table work in bs5
add test for navbar collapse
2024-04-09 12:48:59 +02:00
krassowski
1a04ecde8e Raise NotImplementedError when using reset_managed_roles_on_startup
with the default implementation of `load_managed_roles()`
2024-04-09 11:25:18 +01:00
krassowski
6b8dd277a2 Add a test for load_managed_roles() with username not in database 2024-04-09 11:17:23 +01:00
krassowski
0f1acce363 Add a test & implement keeping user assignments if users key absent 2024-04-09 11:07:15 +01:00
Min RK
044a916488 update setup.py css build step for scss 2024-04-09 11:38:06 +02:00
Min RK
47f39e7c2f changelog for 4.1.5 2024-04-09 11:18:00 +02:00
Min RK
5424108593 singleuser mixin: include check_xsrf_cookie in overrides 2024-04-09 11:18:00 +02:00
krassowski
0424f2938b Fix copy-paste mistake in a comment of a test 2024-04-09 10:15:24 +01:00
krassowski
9dc91fb707 Remove spurious conversion to a list 2024-04-09 10:15:08 +01:00
krassowski
1fa4fa32ce Add Alembic migration for managed_by_auth columns 2024-04-09 09:28:28 +01:00
krassowski
4dd36f5988 Only delete managed roles if not in load_managed_roles() 2024-04-08 15:33:04 +01:00
krassowski
0f0afa178e Do not use caplog in the test as it has multiple known issues
For example https://github.com/pytest-dev/pytest/issues/9236
Here it was passing when running this test alone but not
when run with the other tests.
2024-04-08 14:41:19 +01:00
krassowski
c52b308067 Fix tests which cause subsequent tests to fail with:
`(sqlite3.OperationalError) database is locked`
2024-04-08 14:23:40 +01:00
krassowski
8835f79bf9 Do not delete assignments if given in load_managed_roles() 2024-04-08 14:11:35 +01:00
krassowski
9d0e8e0861 Remove empty managed roles after stripping user of them 2024-04-08 11:34:13 +01:00
krassowski
66c65c93db Warn about not found users/groups/services 2024-04-08 11:04:34 +01:00
krassowski
5aa8d29913 Make role_associations private again 2024-04-07 10:00:42 +01:00
krassowski
4ec2fe3c19 Show offending roles when failing due to assignment in load_roles 2024-04-07 09:55:54 +01:00
krassowski
fcf49be5f6 Fix failing test after addition of managed_by_auth 2024-04-07 09:52:02 +01:00
krassowski
633aa69623 Implement removal of stale managed roles and role assignment 2024-04-05 16:03:14 +01:00
Michał Krassowski
45a67e2d73 Delete the role created in fixture after the test
Co-authored-by: Min RK <benjaminrk@gmail.com>
2024-04-05 14:40:44 +01:00
Min RK
2fe060861a progress toward bootstrap 5 2024-04-04 16:18:01 +02:00
Min RK
cca49486e3 build with sass 2024-04-04 15:58:57 +02:00
Min RK
dfbe7257e6 make it easier to debug static files 2024-04-04 15:58:44 +02:00
Min RK
8c5715621a work on updating to bs5 2024-04-04 12:45:34 +02:00
Min RK
b05b3a30ab autoconvert less to scss
via less2sass:

```
for f in less/*.less; do
    less2sass $f
done

rm -v less/*.less
git mv less scss
```
2024-04-04 12:39:20 +02:00
Min RK
f9fb650a7b Merge pull request #4769 from consideRatio/pr/fix-typo
Fix typo in docstring about Authenticator.blocked_users
2024-04-03 10:49:48 +02:00
Min RK
3ce2643ab7 clarify some allow docs per review 2024-04-02 10:54:17 +02:00
Min RK
3e61e46497 Apply suggestions from code review
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
2024-04-02 10:50:31 +02:00
Erik Sundell
587e6cec4e Fix typo in docstring about Authenticator.blocked_users 2024-04-02 10:42:20 +02:00
Erik Sundell
a6c513c1ac Merge pull request #4767 from jupyterhub/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2024-04-02 08:45:59 +02:00
pre-commit-ci[bot]
b678236f87 [pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.2 → v0.3.5](https://github.com/astral-sh/ruff-pre-commit/compare/v0.3.2...v0.3.5)
2024-04-01 22:10:17 +00:00
Simon Li
11f5759fc7 Merge pull request #4763 from jupyterhub/dependabot/npm_and_yarn/jsx/express-4.19.2
Bump express from 4.18.2 to 4.19.2 in /jsx
2024-04-01 14:35:57 +02:00
Erik Sundell
95db61e613 Merge pull request #4765 from minrk/414-forward
forward-port 4.1.4
2024-03-30 11:10:15 +01:00
Min RK
ab37cd7f24 changelog for 4.1.4 2024-03-30 10:02:43 +01:00
Min RK
26a0be5103 avoid xsrf check on navigate GET requests
sevices/auth prevents calling check_xsrf_cookie,
but if the Handler itself called it the newly strict check would still be applied

this ensures the check is actually allowed for navigate GET requests
2024-03-30 10:02:43 +01:00
dependabot[bot]
9009bf2825 Bump express from 4.18.2 to 4.19.2 in /jsx
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-29 10:03:51 +00:00