Commit Graph

3463 Commits

Author SHA1 Message Date
Min RK
079005eab1 Merge pull request #1643 from minrk/startup-lite
avoid instantiating idle Spawner objects during startup
2018-02-15 15:25:22 +01:00
Robert Schroll
dc8cea3a3e Change base template flag to "templates/" 2018-02-14 16:55:22 -08:00
Robert Schroll
efca88cf8b Always enable the base templates feature 2018-02-14 16:49:11 -08:00
Gladys Nalvarte
c05a6b96b7 Additional information about which ports can be used and which are reserved for internal use only. 2018-02-14 11:06:08 +01:00
Min RK
a831ff3b61 Merge pull request #1653 from dhirschfeld/patch-1
Add PyCharm folder to gitignore
2018-02-12 13:27:02 +01:00
Dave Hirschfeld
b814a09fe6 Add PyCharm folder to gitignore 2018-02-09 12:51:57 +10:00
Min RK
fb48c8626a fix reuse token test now that Spawners are cleaned up after stopping
put the Spawner instance back so it can reuse the token

'real' reuse cases don't need this because the info is stored in their own storage,
e.g. a stopped container.
2018-02-07 11:31:59 +01:00
Min RK
fbdeb4c386 move add_user call for new users to login_user
previous location was in a non-awaitable call
2018-02-07 11:22:47 +01:00
Min RK
4cf9ecc819 spawners are deleted during shutdown 2018-02-06 17:09:59 +01:00
Min RK
e9573b6e24 fixup test_orm with new User wrapper
user.db is evaluated immediately, rather than on first request,
which means we can't do User(orm.User) before adding the orm.User to the db
2018-02-06 17:02:23 +01:00
Min RK
d5f0137052 revert computing user_model from orm.User
always instantiate User wrapper
2018-02-06 15:38:32 +01:00
Min RK
d9f5adb1fb instantiate all User objects during application startup
still avoid instantiating Spawners
2018-02-06 15:38:30 +01:00
Min RK
0c6aa064ac Make User not a HasTraits
HasTraits are expensive to instantiate, so make Users as light as possible

Removes immediate instantiation of Spawners during User init. Spawners will only be instantiated while running
2018-02-06 15:38:08 +01:00
Min RK
646c853cf4 Merge pull request #1648 from thedataincubator/login-redirect
Add option to redirect to running Jupyter server
2018-02-06 15:16:45 +01:00
Min RK
fb3bc95623 Remove expunges from startup 2018-02-06 12:04:14 +01:00
Min RK
c8b4cab022 support getting user models from orm-only User objects
avoids instantiating User wrappers for inactive users in get_all_users
2018-02-06 12:04:14 +01:00
Min RK
06fb94b4ea Delay instantiation of User and Spawner objects
Avoids instantiating too many objects before they are used

- deletes Spawner instances after they stop to avoid lingering instances
- use user_dict cache more often instead of db queries
- check for empty spawners dict to avoid a few Spawner instantiations
2018-02-06 12:04:14 +01:00
Robert Schroll
9f6cef4fb4 Add option to redirect to running Jupyter server
This is how the system used to behave, but now it can be turned off, always
showing the control panel on login.  Adjustment is needed in two places.
2018-02-05 18:12:07 -08:00
Min RK
0315dd5612 avoid instantiating idle Spawner objects during startup
only instantiate Spawners when they are requested
2018-02-02 00:22:47 +01:00
Min RK
e4e5bebc1a Merge pull request #1638 from minrk/404-ok
avoid raising on 404 deleting proxy route
2018-02-01 21:32:52 +01:00
Min RK
c688e9ebad avoid raising on 404 deleting proxy route
deleting a route that doesn't exist should only warn, not error
2018-02-01 20:18:13 +01:00
Min RK
6d6041a3c1 parallelize startup poll
puts each check for a running spawner in a coroutine and runs them all concurrently.

Note: this will only improve performance when a large number of Spawners are running and `yield spawner.poll()` takes a nontrivial amount of time.
This is because these are coroutines, not threads. If instantiating Spawners themselves takes a long time, performance will not be affected.
2018-02-01 20:17:47 +01:00
Min RK
dde7b5ea68 Merge pull request #1642 from minrk/tornado-5-b
Fixes for tests with tornado 5
2018-02-01 19:57:59 +01:00
Min RK
9bf533b340 fixes when tests are run on asyncio
- need to explicitly instantiate asyncio eventloops in background threads
- remove some now-obsolete initialized checks in teardown
2018-02-01 14:56:40 +01:00
Min RK
f1a105abec register tornado's asyncio support at launch time, not import time
avoids other imports from overriding this
2018-02-01 14:49:55 +01:00
Carol Willing
e6587b5dc8 Merge pull request #1631 from minrk/bumps
bump jupyterhub version to 0.9.0.dev
2018-01-24 08:17:54 -08:00
Min RK
b2ad045a2d update docker build hooks
stable is 0.8 (and has been for some time now)
2018-01-24 16:50:49 +01:00
Min RK
89734d8c5f master is 0.9.0.dev
now that we've started making db changes
2018-01-24 16:46:46 +01:00
Min RK
53736099ba specify extra_log_file encoding as utf8
even if locale is ascii

extra_log_file can fail with encoding errors, where stdout logging will escape safely.
2018-01-22 07:39:09 +01:00
Carol Willing
2fcfa136c1 Merge pull request #1625 from jupyterhub/ellisonbg-patch-1
Remove unicode character in favor of plain ->
2018-01-18 15:40:05 -08:00
Brian E. Granger
9f85209a1b Remove unicode character in favor of plain ->
This is still causing problems in all fresh deployments we are doing. I am fine with another solution, but at least wanted to proposed this as a fix for now.
2018-01-18 12:31:17 -08:00
Carol Willing
cea1b2fd4d Merge pull request #1623 from BerserkerTroll/patch-1
Fix Authentication state documentation
2018-01-17 09:28:22 -08:00
BerserkerTroll
312252b670 Fix Authentication state documentation
This — is how it actually works!
2018-01-17 05:45:47 +03:00
Min RK
4d6b30c17b Merge pull request #1621 from consideRatio/master
Fix spawner/service typo in proxy.py
2018-01-13 13:20:44 -08:00
Erik Sundell
0beb9c2670 fix spawner/service typo in proxy.py 2018-01-13 21:43:09 +01:00
Min RK
a0289af59f Merge pull request #1615 from yuvipanda/hub_connect_ip
Add note about hub_connect_ip restrictions
2018-01-12 17:38:16 -08:00
Carol Willing
40363834c8 Merge pull request #1619 from timfreund/linkupdate
Update docker volumes link
2018-01-12 09:08:47 -08:00
Tim Freund
0c9e5fd10b Update docker volumes link
The old link now returns 404.
2018-01-11 21:28:24 -05:00
yuvipanda
3d90e5cdf6 Add note about hub_connect_ip restrictions
Kubernets Ingress Proxy requires IPs, and I suspect other
proxies in the future might have DNS restrictions too.
This causes confusion, in cases like
https://github.com/jupyterhub/kubespawner/issues/116.
2018-01-10 18:35:58 -08:00
Robert Schroll
8e3f1f0955 Add a block around the message in the spawn_pending page
This makes it easier for users to add or substitute custom messages on
this page.
2018-01-04 15:34:59 -08:00
Robert Schroll
7c64415096 Add base_template option
If true, the user can have custom templates (specified in
template_paths) that extend the default templates, by referencing them
as "BASE:filename.html".  This makes it easier to add information to
exising templates.
2018-01-04 15:34:59 -08:00
Min RK
e3fd1dba0e Merge pull request #1609 from minrk/tornado-5
tornado 5 fixes
2018-01-03 18:24:07 +01:00
Min RK
9866a0fadc avoid raising HTTPError in get_current_user
it can cause issues, e.g. with upcoming notebook releases .get_current_user may be called in set_default_headers,
which doesn't catch HTTPErrors.
2018-01-03 14:58:42 +01:00
Min RK
f87f24d9e5 unpin tornado 2018-01-03 14:12:29 +01:00
Min RK
4729ae4769 tornado 5 fixes
- ._running private attribute is removed. We don't need it anymore,
  since we were only using it while the application was run in a background thread.
- call blocking cleanup in a thread because asyncio doesn't allow multiple loops in one thread.
2018-01-03 14:12:23 +01:00
Min RK
691c4c158f Merge pull request #1606 from willingc/test-readme
Add CHP to dev install and move to CONTRIBUTING
2018-01-03 11:52:27 +01:00
Carol Willing
3c597339ba Add CHP to dev install and move to CONTRIBUTING 2018-01-03 11:52:01 +01:00
Min RK
e5fe174e03 Merge pull request #1607 from willingc/travis-tornado
pin tornado requirement to less than 5.0
2018-01-03 11:50:18 +01:00
Carol Willing
1c25a9d026 pin tornado requirement to less than 5.0 2018-01-02 15:19:35 -08:00
Min RK
2db378e9c1 Merge pull request #1577 from minrk/session-cookie
add session-id cookie
2017-12-19 15:18:02 +01:00