Yuvi Panda
f7b90e2c09
Merge pull request #1400 from minrk/auth-custom-html
...
allow Authenticator.custom_html to be HTML
2017-09-06 11:56:14 -07:00
Carol Willing
ccb29167dd
Merge pull request #1392 from minrk/rm-extra-log
...
update docs to preferred method of writing to log file
2017-09-06 07:32:25 -07:00
Min RK
4ef1eca3c9
allow Authenticator.custom_html to be HTML
2017-09-06 15:14:26 +02:00
Min RK
c26ede30b9
Point users to /hub/home to retry spawn on spawn failure
2017-09-06 15:03:26 +02:00
Min RK
64c69a3164
update docs to preferred method of writing to log file
...
extra_log_files config is unreliable and doesn't capture all output.
Piping output is much more robust and reliable.
2017-09-06 14:38:33 +02:00
Min RK
ad7867ff11
add trailing slash on /user/name
...
proxies may not route `/user/name` correctly, only `/user/name/...`, so make sure that `/user/name` is redirected to `/user/name/`
this manifests as a redirect loop between /user/name and /hub/user/name when a route exists but /user/name is still
being routed to the Hub
2017-09-06 12:37:22 +02:00
Yuvi Panda
14fc1588f8
Merge pull request #1380 from minrk/cull-idle-users
...
add —cull-users to cull_idle_servers
2017-09-05 12:48:24 -07:00
Min RK
7e5a925f4f
raise original spawn failure on implicit spawn
...
so the error message is the same, however it was arrived at.
potential downside: it could look like the current request is spawning and failing,
rather than the reality that a previous spawn failed and we are just re-presenting the earlier error.
It's possible for there to have been a long time in between spawn and error.
2017-09-04 14:27:01 +02:00
Min RK
3c61e422da
prevent implicit spawn on /user/:name if previous spawn failed
...
require users to visit /hub/home and click 'Start My Server' to get a new server
Visits to /hub/user/:name will get an error if the previous spawn failed,
rather than triggering a new spawn.
This should guarantee that a user sees an error if their spawn failed,
regardless of when the failure occurred and how long it took.
Some cases of slow errors could result in triggering a new spawn indefinitely without
the user seeing an error message.
/hub/spawn was a simple redirect to /user/:name in the absence of a spawn form,
but now clears the `_spawn_future` prior to redirect
to signal that a new spawn has been explicitly requested in the case of a prior failure.
2017-09-04 14:17:24 +02:00
Min RK
0e2cf37981
point to single-user logs when spawner fails to start
2017-09-04 13:14:07 +02:00
Min RK
503d5e389f
render pending page if triggered spawn doesn't finish
...
instead of redirecting, which starts redirect loop counter
2017-09-04 12:02:40 +02:00
Min RK
7b1e61ab2c
allow waiting for pending spawn via spawner._spawn_future
...
avoids losing errors when visiting `/hub/user/:name` during a pending spawn
2017-09-04 11:53:42 +02:00
Min RK
4692d6638d
0.8.0b4
2017-08-31 16:47:12 +02:00
Carol Willing
7829070e1c
Merge pull request #1383 from minrk/singleuser-token-cookie
...
set cookie on singleuser when authenticated with ?token=...
2017-08-31 09:31:35 -05:00
Min RK
5e4b935322
only HubOAuth can set token cookie
2017-08-31 16:04:54 +02:00
Carol Willing
4c445c7a88
Add jencabral to contributors
2017-08-31 07:52:08 -05:00
Carol Willing
8e2965df6a
Merge pull request #1384 from minrk/spawner-db
...
restore db access on Spawner
2017-08-31 07:50:18 -05:00
Min RK
7a41d24606
set cookie on singleuser when authenticated with ?token=...
...
Allows `/user/name?token=...` URL to login users for more than one request.
matches token behavior of regular notebook server.
2017-08-31 13:53:48 +02:00
Min RK
5f84a006dc
restore db access on Spawner
...
Shouldn’t be strictly necessary, but doesn’t hurt
2017-08-31 10:03:44 +02:00
Carol Willing
e19296a230
Merge pull request #1382 from minrk/request-token
...
let admins request tokens for other users
2017-08-31 00:04:59 -04:00
Min RK
89ba97f413
exercise more token API cases
...
separate parametrize cases for clarity
2017-08-30 14:38:00 +02:00
Min RK
fe2157130b
Merge pull request #1381 from minrk/log-fix
...
fix logging error when login_user is called with no form data and login fails
2017-08-30 14:09:52 +02:00
Min RK
e3b17e8176
Merge pull request #1379 from ding-c3/master
...
Pass timeout value to exponential_backoff in wait functions
2017-08-30 14:05:42 +02:00
Min RK
027f2f95c6
let admins request tokens for other users
2017-08-30 12:31:41 +02:00
Min RK
210975324a
fix logging error when login_user is called with no form data and login fails
2017-08-30 11:31:44 +02:00
Min RK
f9a90d2494
add —cull-users to cull_idle_servers
...
allows deleting idle users in addition to servers for temp-user cases such as binder/tmpnb
2017-08-30 10:31:44 +02:00
Alex Ding
932689f2f8
Pass timeout value to exponential_backoff in wait functions
2017-08-29 17:45:21 -07:00
Min RK
f91e911d1a
Merge pull request #1375 from lsst-sqre/master
...
Prevent "extra" from being used before definition.
2017-08-29 08:36:25 -04:00
Adam Thornton
b75cce857e
Merge pull request #1 from lsst-sqre/ticket/DM-11663
...
Fix "extra" so it isn't used before definition.
2017-08-28 19:00:17 -04:00
adam
62f00690f7
Fix "extra" so it isn't used before definition.
2017-08-28 15:58:31 -07:00
Yuvi Panda
f700ba4154
Merge pull request #1368 from minrk/check-version-error
...
Provide more detailed error message in case of version mismatch
2017-08-28 13:27:00 -04:00
Min RK
8b91842eae
Merge pull request #1369 from minrk/template-typo
...
typo in navbar template
2017-08-27 16:41:44 -04:00
Min RK
80a9eb93f4
Merge pull request #1370 from yuvipanda/button-roles
...
Add role=button attribute to all <a> & <span> buttons
2017-08-27 15:39:04 -04:00
yuvipanda
e1deecbbfb
Add role=button attribute to all <a> & <span> buttons
...
Simple accessibility win - screen readers will now be
able to properly present these as buttons than links.
2017-08-27 11:17:22 -04:00
Min RK
d3142704b7
typo in navbar template
...
mixed up elements causing funky alignment on some pages
2017-08-26 22:42:17 -04:00
Min RK
447edd081a
Provide more detailed error message in case of version mismatch
...
this is the most likely cause of redirect loops when using docker,
so record the spawner version and check it when a redirect is detected.
In the event of a redirect and mismatch, fail with a message explaining the version mismatch and how to fix it.
2017-08-26 22:41:24 -04:00
Min RK
e1531ec277
Merge pull request #1366 from minrk/typo
...
typo in proxy recovery
2017-08-26 20:21:51 -04:00
Min RK
d12ac4b1f6
typo in proxy recovery
...
should have been the dict of instantiated services, not the list of service configurations
2017-08-26 15:25:17 -04:00
Min RK
17851b7586
0.8.0b3
2017-08-26 13:51:12 -04:00
Min RK
118e2fa610
Merge pull request #1364 from minrk/test-start-stop-race
...
exercise start/stop race conditions
2017-08-26 13:37:41 -04:00
Min RK
8e3553462c
exercise start/stop race conditions
...
this doesn’t cover all the edge cases of each possible stage for the races, but it gets the basics covered.
2017-08-26 11:57:05 -04:00
Carol Willing
37da47d811
Merge pull request #1356 from minrk/proxy-race
...
rework spawn futures to fix races
2017-08-26 11:07:55 -04:00
Min RK
a640a468fb
Merge pull request #1362 from stuartcampbell/master
...
Improve help comments for SSL key/certs configuration parameters
2017-08-26 09:41:47 -04:00
Min RK
92f034766e
Merge pull request #1355 from minrk/update-oauth-secret
...
update oauth secret if API tokens change
2017-08-26 09:41:14 -04:00
Min RK
f7ea451df8
get the tests running
2017-08-25 18:12:15 -04:00
Stuart Campbell
1b7f54b462
Make SSL cert/key help clearer.
2017-08-25 14:52:23 -04:00
Stuart Campbell
b14b12231a
Correct typo to have consistent comments
2017-08-24 16:53:25 -04:00
Min RK
2866be9462
don’t allow start while stop is pending
...
- start fails with 400 if stop is pending
- set spawn_pending across a whole spawn (including proxy)
- proxy_pending is only around the proxy
2017-08-23 23:35:19 -04:00
Min RK
f8648644bf
ensure _stop_pending is always True on stop_single_user
...
previously there was a race during `delete_route`
apply the same logic as _start_pending
2017-08-23 18:30:49 -04:00
Min RK
69d4d48db0
rework spawn futures to fix races
...
1. set _proxy_pending before first wait to ensure that there is never a gap between setting spawn flags
2. always call `finish_user_spawn` to reduce the number of finalization cases
3. wait for proxy to finish on the slow_spawn timeout, not just start, because we are only interested in the total duration for page responsiveness
2017-08-21 11:27:30 +02:00
