Commit Graph

2053 Commits

Author SHA1 Message Date
Min RK
9a555d8a6e move user.proxy_pending to Spawner._proxy_pending 2017-07-24 15:22:36 +02:00
Min RK
f7bf2b0ba6 Merge branch 'master' into named_servers 2017-07-24 15:21:42 +02:00
Min RK
710ed0a5c8 Merge pull request #1245 from willingc/deduplicate
Review and edit security documentation
2017-07-24 14:35:33 +02:00
Min RK
7539523ef2 Merge pull request #1251 from yuvipanda/another-race-maybe
Don't add route if there's already a route addition pending
2017-07-24 14:34:34 +02:00
Yuvi Panda
c97444e438 Merge pull request #1257 from minrk/dirty
Dirty database fixes
2017-07-24 05:19:19 -07:00
Min RK
4c86d10037 comment about sqlachemy dirty flag 2017-07-24 14:12:50 +02:00
Min RK
69a6c79558 use admin user in test_admin
rather than relying on multi db sessions talking to each other
2017-07-24 13:37:11 +02:00
yuvipanda
a0466dc322 Count ourselves as a good route if we've a proxy pending 2017-07-24 04:35:13 -07:00
Min RK
546e35e9a3 Merge pull request #1249 from Carreau/fix-pam-500
Do not 500 if cannot authenticate.
2017-07-24 12:54:56 +02:00
Min RK
ce53b11cf7 Make rollback conditional on db.dirty
avoids calling rollback when there are no changes

includes warning about what objects are actually dirty
2017-07-24 12:53:58 +02:00
Min RK
1229fd100f only set attributes on orm_server if they changed
Setting things on orm_server set the dirty flag,
even if they haven't changed.
2017-07-24 12:52:46 +02:00
Matthias Bussonnier
e4541591ea Do not 500 if cannot authenticate.
self.authenticate can return None, in which case you can't subscript.
So move extracting data into the branch checking whether authenticate is
not `None`.

Now that extracting the username is inside the if branch, it can't be
used in the else one, so extract username from the request itself.

This can be easily reproduce with the default PAM login with a wrong
non existing/ wrong username.
2017-07-21 15:40:28 -07:00
Carol Willing
be62b1b9df Reword based on @minrk's review 2017-07-21 11:47:24 -07:00
Carol Willing
9c21cf4c62 Add @minrk review comments 2017-07-21 11:32:48 -07:00
Carol Willing
51af6a98cc Be clearer about the config file name 2017-07-21 11:23:43 -07:00
Carol Willing
520d6160f0 Make use of config file and environment variable consistent 2017-07-21 11:23:43 -07:00
Carol Willing
e8ebedb2da Move security audits to overview doc 2017-07-21 11:23:43 -07:00
Carol Willing
fd7700d577 Update title 2017-07-21 11:23:43 -07:00
Carol Willing
6ee88a5424 Edit content for clarity 2017-07-21 11:23:43 -07:00
Carol Willing
c89711d0d5 Edit and deduplicate security docs 2017-07-21 11:23:43 -07:00
Carol Willing
daee0f8df8 Merge pull request #1248 from Carreau/cleanup
Remove unused import and add version to deprecations.
2017-07-21 11:21:20 -07:00
Matthias Bussonnier
e1444f4aca remove trailing comma 2017-07-21 11:13:18 -07:00
Matthias Bussonnier
97b9c4899a typo 2017-07-21 11:12:24 -07:00
Matthias Bussonnier
b8aa6ecd70 Remove unused import and add version to deprecations. 2017-07-21 10:23:54 -07:00
Min RK
e28f3947bd Merge branch 'master' into named_servers 2017-07-21 15:43:09 +02:00
Min RK
bc9cc98789 Merge pull request #1246 from yuvipanda/no-unconditional-add
Don't unconditionally add hub route to proxy
2017-07-21 10:23:25 +02:00
yuvipanda
72132e7946 Don't unconditionally add hub route to proxy
This is done contidtionally in check_routes instead
2017-07-21 01:01:21 -07:00
Carol Willing
b0307dd98e Merge pull request #1242 from minrk/headers-fixes
various singleuser header fixes
2017-07-20 11:49:13 -07:00
Carol Willing
fd1ac55a70 Merge pull request #1240 from minrk/drop-33
Require Python 3.4
2017-07-20 11:25:30 -07:00
Yuvi Panda
39d8800389 Merge pull request #1241 from minrk/progress-spin
add spinner to slow-spawn page
2017-07-20 09:59:32 -07:00
Min RK
382a7121e1 further clear up named servers
- use spawner.server instead of user.server
- user.running, proxy_spec are methods that take spawner names
2017-07-20 16:54:17 +02:00
Min RK
4c0ac6d502 Merge pull request #1234 from CRegenschein/master
Add pre_spawn_hook
2017-07-20 15:45:06 +02:00
Min RK
40dcbedc2a various singleuser header fixes
- always set content security policy header, to workaround bug in notebook 5.0
- set x-jupyterhub-version on all requests, not just our own
- fix version comparison in _check_version (leftover `__version__`)
- even log version matches at debug-level (verifies that check happened)
2017-07-20 15:37:54 +02:00
Min RK
9eda66b3ae bump bower dependencies
need fa 4.3 for fa-pulse, but rev everything while we're at it
2017-07-20 14:31:13 +02:00
Min RK
d4c48db248 add spinner on slow-spawn page 2017-07-20 14:30:45 +02:00
Min RK
7bd4861689 minor cleanup in pre_spawn_hook
- remove reduntant None, allow_none in Any
- remove callable check (if it's not callable, let the error raise)
- let outer error handling deal with failed pre-spawn hook
- add missing `return` in pre_spawn_hook
2017-07-20 14:08:06 +02:00
CRegenschein
72550725da jupyterhub-1219 Enhancement: automatically create a directory for the user after successful login 2017-07-20 14:02:13 +02:00
Min RK
5a8011ea66 Require Python 3.4
Specify Requires-Python (PEP345) metadata
2017-07-20 13:49:34 +02:00
Min RK
0fd1a95405 Merge pull request #1239 from willingc/remove-33
Bump Python support to 3.4 and up
2017-07-20 13:48:56 +02:00
Min RK
8d0cfa8e7c always set content-type json on API handlers 2017-07-20 11:58:50 +02:00
Min RK
3d1187283c apply stricter CSP on api endpoints
double-ensure that no scripts run on api pages (referrer check already doesn't allow malicious links)
2017-07-20 11:58:50 +02:00
Carol Willing
7416a55083 Add test for invalid version 2017-07-19 19:23:37 -07:00
Carol Willing
e8a3c4dac6 Fix link 2017-07-19 17:33:14 -07:00
Carol Willing
33f2026dac Add badge for 0.7.2 docs to README 2017-07-19 17:30:57 -07:00
Carol Willing
d34f6e779d Bump Python support to 3.4 and up 2017-07-19 14:57:52 -07:00
Min RK
738976a956 Merge pull request #1236 from willingc/doc-intro
Break up long Getting Started doc page
2017-07-19 11:40:39 +02:00
Carol Willing
fd8cc1df15 Break up large getting started doc 2017-07-18 17:57:56 -07:00
Carol Willing
61053b063e Reorganize content 2017-07-18 16:47:11 -07:00
Carol Willing
a27e1e9d40 Break up installation document 2017-07-18 11:45:03 -07:00
Carol Willing
a7889eb536 Rename guide to reference 2017-07-18 11:03:49 -07:00