Commit Graph

18 Commits

Author SHA1 Message Date
Min RK
5e166970fa easier linting in jupyterhub_config
noqa get_import satisfies most linters
2024-03-11 09:16:02 +01:00
pre-commit-ci[bot]
ef568e3d61 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2024-02-05 20:27:29 +00:00
pre-commit-ci[bot]
42488fdb12 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-06 16:45:17 +00:00
YuviPanda
3865df7db0 Move boilerplate to the bottom 2023-09-06 09:41:24 -07:00
YuviPanda
53c5a5001b Fix external-oauth example jupyterhub_config.py
- Roles need to be explicitly granted, otherwise you get a
  403. This example predates roles.
- Explicitly set bind_url - without this, JupyterHub itself doesn't
  seem to bind anywhere, and so you just get a 404 when you visit
  whatever port configurable-http-proxy lands on. This is probably
  a separate bug to be investigated, but in the meantime copying
  this from testing/jupyterhub_config.py makes this example actually
  work
- Set DummyAuthenticator as the default, so users can get started
  with this example
2023-09-05 16:27:00 -07:00
YuviPanda
6ea33fa7cc Document oauth_client_id must start with service-
Enforced here: 7f50a0a7fa/jupyterhub/services/service.py (L327)
2023-09-05 15:21:50 -07:00
Min RK
7a9778249f run pre-commit with isort 2022-03-31 12:33:26 +02:00
Eric Charles
16636ce3c0 Fix Service oauth client ids must start with 'service-' in the service launcher 2021-05-20 12:00:56 +02:00
Eric Charles
fdf57b271e Fix Service oauth client ids must start with 'service-' 2021-05-20 11:58:42 +02:00
Min RK
9331dd13da run pre-commit (prettier) 2021-02-12 15:25:58 +01:00
Steffen Vogel
e93cc83d58 remove unused imports 2020-04-16 12:12:22 +02:00
Min RK
5e60582ef3 run autoformat
apologies to anyone finding this commit via git blame or log

run the autoformatting by

    pre-commit run --all-files
2019-02-19 17:00:10 +01:00
Matthias Bussonnier
2e872069fb Use $() for command substitution instead of backticks/quotes.
One of the example was using quotes instead of backticks.
Backticks are the "older" way of doing things, which has a number of
disadvantes:

    http://mywiki.wooledge.org/BashFAQ/082

Here I'm more worried about readability as depending on font and "smart"
editor helping on the web, many people may confuse ` with ', it could
end up modifying formatting on makrdown powered website... etc...
2018-10-04 13:44:16 -07:00
Min RK
ec784803b4 remove duplicate whoami-oauth.py from external-oauth example 2018-05-07 15:35:05 +02:00
Min RK
98d3b538af Further clarifications in external-oauth example 2018-03-13 10:03:01 +01:00
Min RK
8b3c2fa12f add whoami-oauth-basic example
implements oauth without inheriting from HubOAuthenticated

should be easier to parse for users with alternate oauth implementations
2018-03-13 10:03:01 +01:00
Min RK
079b0c1b91 feedback in README 2018-02-23 13:44:07 +01:00
Min RK
6970df4dda add external oauth example 2018-02-22 17:01:00 +01:00