Merge pull request #5162 from minrk/linkcheck

linkcheck: npmjs 403s from CI
2025-10-07 01:54:09 +00:00 · 2025-10-02 15:19:13 -07:00 · 2025-10-02 15:08:38 -07:00 · 2025-10-02 23:26:02 +02:00 · 2025-10-02 13:30:17 -07:00
4 changed files with 11 additions and 3 deletions
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -298,6 +298,7 @@ linkcheck_ignore = [
    r"https://github.com/jupyterhub/jupyterhub/security/advisories/.*",
    # Occasionally blocks CI checks with 403
    r"https://www\.mysql\.com",
+    r"https://www\.npmjs\.com",
    # Occasionally blocks CI checks with SSL error
    r"https://mediaspace\.msu\.edu/.*",
 ]
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -1989,7 +1989,10 @@ class JupyterHub(Application):
                self.internal_ssl_cert,
                cafile=self.internal_ssl_ca,
            )
-            AsyncHTTPClient.configure(None, defaults={"ssl_options": ssl_context})
+            AsyncHTTPClient.configure(
+                AsyncHTTPClient.configured_class(),
+                defaults={"ssl_options": ssl_context},
+            )

    def init_db(self):
        """Create the database connection"""
--- a/jupyterhub/singleuser/extension.py
+++ b/jupyterhub/singleuser/extension.py
@@ -330,7 +330,9 @@ class JupyterHubSingleUser(ExtensionApp):
            self.hub_auth.certfile,
            cafile=self.hub_auth.client_ca,
        )
-        AsyncHTTPClient.configure(None, defaults={"ssl_options": ssl_context})
+        AsyncHTTPClient.configure(
+            AsyncHTTPClient.configured_class(), defaults={"ssl_options": ssl_context}
+        )
        return AsyncHTTPClient()

    async def check_hub_version(self):
--- a/jupyterhub/singleuser/mixins.py
+++ b/jupyterhub/singleuser/mixins.py
@@ -406,7 +406,9 @@ class SingleUserNotebookAppMixin(Configurable):
        ssl_context = make_ssl_context(
            self.keyfile, self.certfile, cafile=self.client_ca
        )
-        AsyncHTTPClient.configure(None, defaults={"ssl_options": ssl_context})
+        AsyncHTTPClient.configure(
+            AsyncHTTPClient.configured_class(), defaults={"ssl_options": ssl_context}
+        )
        return AsyncHTTPClient()

    async def check_hub_version(self):
Author	SHA1	Message	Date
Min RK	dc69ff4126	Merge pull request #5162 from minrk/linkcheck linkcheck: npmjs 403s from CI	2025-10-02 15:19:13 -07:00
Min RK	024fe661e5	linkcheck: npmjs 403s from CI	2025-10-02 15:08:38 -07:00
Erik Sundell	6f05534dd8	Merge pull request #5159 from minrk/internal-ssl-pycurl don't revert asynchttp class when setting up internal ssl	2025-10-02 23:26:02 +02:00
Min RK	485ac0df4c	don't change asynchttp class when setting up internal ssl None reverts to the default class, it doesn't not preserve the current value	2025-10-02 13:30:17 -07:00