mirror of
https://github.com/jupyterhub/jupyterhub.git
synced 2025-10-08 02:24:08 +00:00
a09f535e8f
In case there are multiple singleuser notebooks at different versions we want to log each of those mismatches as a warning so this changes the global _version_mismatch_warning_logged flag from a bool to a dict keyed by the hub/singleuser version mismatch combination. A test wrinkle is added for that scenario. Part of #2970
57 lines
1.7 KiB
Python
57 lines
1.7 KiB
Python
"""Test version checking"""
|
|
import logging
|
|
|
|
import pytest
|
|
|
|
from .._version import _check_version
|
|
from .._version import reset_globals
|
|
|
|
|
|
def setup_function(function):
|
|
reset_globals()
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
'hub_version, singleuser_version, log_level, msg',
|
|
[
|
|
('0.8.0', '0.8.0', logging.DEBUG, 'both on version'),
|
|
('0.8.0', '0.8.1', logging.DEBUG, ''),
|
|
('0.8.0', '0.8.0.dev', logging.DEBUG, ''),
|
|
('0.8.0', '0.9.0', logging.WARNING, 'This could cause failure to authenticate'),
|
|
('', '0.8.0', logging.WARNING, 'Hub has no version header'),
|
|
('0.8.0', '', logging.WARNING, 'Single-user server has no version header'),
|
|
],
|
|
)
|
|
def test_check_version(hub_version, singleuser_version, log_level, msg, caplog):
|
|
log = logging.getLogger()
|
|
caplog.set_level(logging.DEBUG)
|
|
_check_version(hub_version, singleuser_version, log)
|
|
assert len(caplog.records) == 1
|
|
record = caplog.records[0]
|
|
assert record.levelno == log_level
|
|
assert msg in record.getMessage()
|
|
|
|
|
|
def test_check_version_singleton(caplog):
|
|
"""Tests that minor version difference logging is only logged once."""
|
|
# Run test_check_version twice which will assert that the warning is only logged
|
|
# once.
|
|
for x in range(2):
|
|
test_check_version(
|
|
'1.2.0',
|
|
'1.1.0',
|
|
logging.WARNING,
|
|
'This could cause failure to authenticate',
|
|
caplog,
|
|
)
|
|
# Run it again with a different singleuser_version to make sure that is logged as
|
|
# a warning.
|
|
caplog.clear()
|
|
test_check_version(
|
|
'1.2.0',
|
|
'1.1.1',
|
|
logging.WARNING,
|
|
'This could cause failure to authenticate',
|
|
caplog,
|
|
)
|