1
0

[DURACOM-191] fix some tests

This commit is contained in:
Andrea Barbasso
2024-03-14 17:24:03 +01:00
parent 87552ce5d6
commit 1a14f3fb75
8 changed files with 39 additions and 23 deletions

View File

@@ -21,9 +21,9 @@ describe('AdminNotifyMetricsComponent', () => {
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [TranslateModule.forRoot(), AdminNotifyMetricsComponent], imports: [TranslateModule.forRoot(), AdminNotifyMetricsComponent],
providers: [{ provide: Router, useValue: router }] providers: [{ provide: Router, useValue: router }],
}) })
.compileComponents(); .compileComponents();

View File

@@ -13,6 +13,7 @@ import {
of, of,
} from 'rxjs'; } from 'rxjs';
import { APP_DATA_SERVICES_MAP } from '../../../../config/app-config.interface';
import { RemoteDataBuildService } from '../../../core/cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../../../core/cache/builders/remote-data-build.service';
import { ObjectCacheService } from '../../../core/cache/object-cache.service'; import { ObjectCacheService } from '../../../core/cache/object-cache.service';
import { RequestService } from '../../../core/data/request.service'; import { RequestService } from '../../../core/data/request.service';
@@ -23,6 +24,8 @@ import { SearchConfigurationService } from '../../../core/shared/search/search-c
import { SEARCH_CONFIG_SERVICE } from '../../../my-dspace-page/my-dspace-configuration.service'; import { SEARCH_CONFIG_SERVICE } from '../../../my-dspace-page/my-dspace-configuration.service';
import { routeServiceStub } from '../../../shared/testing/route-service.stub'; import { routeServiceStub } from '../../../shared/testing/route-service.stub';
import { RouterStub } from '../../../shared/testing/router.stub'; import { RouterStub } from '../../../shared/testing/router.stub';
import { TruncatableComponent } from '../../../shared/truncatable/truncatable.component';
import { TruncatablePartComponent } from '../../../shared/truncatable/truncatable-part/truncatable-part.component';
import { AdminNotifyDetailModalComponent } from '../admin-notify-detail-modal/admin-notify-detail-modal.component'; import { AdminNotifyDetailModalComponent } from '../admin-notify-detail-modal/admin-notify-detail-modal.component';
import { AdminNotifyMessage } from '../models/admin-notify-message.model'; import { AdminNotifyMessage } from '../models/admin-notify-message.model';
import { AdminNotifyMessagesService } from '../services/admin-notify-messages.service'; import { AdminNotifyMessagesService } from '../services/admin-notify-messages.service';
@@ -128,8 +131,8 @@ describe('AdminNotifySearchResultComponent', () => {
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [TranslateModule.forRoot(), AdminNotifySearchResultComponent, AdminNotifyDetailModalComponent], imports: [TranslateModule.forRoot(), AdminNotifySearchResultComponent, AdminNotifyDetailModalComponent],
providers: [ providers: [
{ provide: AdminNotifyMessagesService, useValue: adminNotifyMessageService }, { provide: AdminNotifyMessagesService, useValue: adminNotifyMessageService },
{ provide: RouteService, useValue: routeServiceStub }, { provide: RouteService, useValue: routeServiceStub },
{ provide: ActivatedRoute, useValue: new RouterStub() }, { provide: ActivatedRoute, useValue: new RouterStub() },
@@ -138,10 +141,19 @@ describe('AdminNotifySearchResultComponent', () => {
{ provide: RequestService, useValue: requestService }, { provide: RequestService, useValue: requestService },
{ provide: RemoteDataBuildService, useValue: rdbService }, { provide: RemoteDataBuildService, useValue: rdbService },
{ provide: SEARCH_CONFIG_SERVICE, useValue: searchConfigService }, { provide: SEARCH_CONFIG_SERVICE, useValue: searchConfigService },
{ provide: APP_DATA_SERVICES_MAP, useValue: {} },
DatePipe, DatePipe,
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA],
}) })
.overrideComponent(AdminNotifySearchResultComponent, {
remove: {
imports: [
TruncatableComponent,
TruncatablePartComponent,
],
},
})
.compileComponents(); .compileComponents();
fixture = TestBed.createComponent(AdminNotifySearchResultComponent); fixture = TestBed.createComponent(AdminNotifySearchResultComponent);

View File

@@ -66,7 +66,7 @@ describe('JournalIssueGridElementComponent', () => {
}).overrideComponent(JournalIssueGridElementComponent, { }).overrideComponent(JournalIssueGridElementComponent, {
add: { changeDetection: ChangeDetectionStrategy.Default }, add: { changeDetection: ChangeDetectionStrategy.Default },
remove: { remove: {
providers: [JournalIssueSearchResultGridElementComponent], imports: [JournalIssueSearchResultGridElementComponent],
}, },
}).compileComponents(); }).compileComponents();
})); }));

View File

@@ -18,11 +18,15 @@ import { Item } from '../../../../../core/shared/item.model';
import { DSONameServiceMock } from '../../../../../shared/mocks/dso-name.service.mock'; import { DSONameServiceMock } from '../../../../../shared/mocks/dso-name.service.mock';
import { mockTruncatableService } from '../../../../../shared/mocks/mock-trucatable.service'; import { mockTruncatableService } from '../../../../../shared/mocks/mock-trucatable.service';
import { getMockThemeService } from '../../../../../shared/mocks/theme-service.mock'; import { getMockThemeService } from '../../../../../shared/mocks/theme-service.mock';
import { ThemedBadgesComponent } from '../../../../../shared/object-collection/shared/badges/themed-badges.component';
import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { ActivatedRouteStub } from '../../../../../shared/testing/active-router.stub'; import { ActivatedRouteStub } from '../../../../../shared/testing/active-router.stub';
import { ThemeService } from '../../../../../shared/theme-support/theme.service'; import { ThemeService } from '../../../../../shared/theme-support/theme.service';
import { TruncatableComponent } from '../../../../../shared/truncatable/truncatable.component';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
import { TruncatablePartComponent } from '../../../../../shared/truncatable/truncatable-part/truncatable-part.component';
import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { ThumbnailComponent } from '../../../../../thumbnail/thumbnail.component';
import { JournalIssueSearchResultListElementComponent } from './journal-issue-search-result-list-element.component'; import { JournalIssueSearchResultListElementComponent } from './journal-issue-search-result-list-element.component';
let journalIssueListElementComponent: JournalIssueSearchResultListElementComponent; let journalIssueListElementComponent: JournalIssueSearchResultListElementComponent;
@@ -102,7 +106,10 @@ describe('JournalIssueSearchResultListElementComponent', () => {
], ],
schemas: [NO_ERRORS_SCHEMA], schemas: [NO_ERRORS_SCHEMA],
}).overrideComponent(JournalIssueSearchResultListElementComponent, { }).overrideComponent(JournalIssueSearchResultListElementComponent, {
add: { changeDetection: ChangeDetectionStrategy.Default } }, add: { changeDetection: ChangeDetectionStrategy.Default } ,
remove: {
imports: [ThumbnailComponent, ThemedBadgesComponent, TruncatableComponent, TruncatablePartComponent],
} },
).compileComponents(); ).compileComponents();
})); }));

View File

@@ -28,12 +28,8 @@ import { MyDSpaceConfigurationValueType } from './my-dspace-configuration-value-
import { MyDSpaceNewSubmissionComponent } from './my-dspace-new-submission/my-dspace-new-submission.component'; import { MyDSpaceNewSubmissionComponent } from './my-dspace-new-submission/my-dspace-new-submission.component';
import { MyDSpacePageComponent } from './my-dspace-page.component'; import { MyDSpacePageComponent } from './my-dspace-page.component';
import SpyObj = jasmine.SpyObj; import SpyObj = jasmine.SpyObj;
import { import { SuggestionsNotificationComponent } from '../notifications/suggestions-notification/suggestions-notification.component';
SuggestionsNotificationComponent import { MyDspaceQaEventsNotificationsComponent } from './my-dspace-qa-events-notifications/my-dspace-qa-events-notifications.component';
} from '../notifications/suggestions-notification/suggestions-notification.component';
import {
MyDspaceQaEventsNotificationsComponent
} from './my-dspace-qa-events-notifications/my-dspace-qa-events-notifications.component';
describe('MyDSpacePageComponent', () => { describe('MyDSpacePageComponent', () => {
let comp: MyDSpacePageComponent; let comp: MyDSpacePageComponent;

View File

@@ -131,9 +131,9 @@ describe('ProcessOverviewTableComponent', () => {
init(); init();
void TestBed.configureTestingModule({ void TestBed.configureTestingModule({
declarations: [NgbCollapse], declarations: [NgbCollapse],
imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), VarDirective, ProcessOverviewTableComponent], imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), VarDirective, ProcessOverviewTableComponent],
providers: [ providers: [
{ provide: ProcessOverviewService, useValue: processOverviewService }, { provide: ProcessOverviewService, useValue: processOverviewService },
{ provide: ProcessDataService, useValue: processService }, { provide: ProcessDataService, useValue: processService },
{ provide: EPersonDataService, useValue: ePersonService }, { provide: EPersonDataService, useValue: ePersonService },
@@ -142,8 +142,8 @@ describe('ProcessOverviewTableComponent', () => {
{ provide: NgbModal, useValue: modalService }, { provide: NgbModal, useValue: modalService },
{ provide: AuthService, useValue: authService }, { provide: AuthService, useValue: authService },
{ provide: RouteService, useValue: routeService }, { provide: RouteService, useValue: routeService },
] ],
}).compileComponents(); }).compileComponents();
})); }));
beforeEach(() => { beforeEach(() => {

View File

@@ -31,6 +31,7 @@ import { MetadataValue } from '../../../core/shared/metadata.models';
import { SubmissionScopeType } from '../../../core/submission/submission-scope-type'; import { SubmissionScopeType } from '../../../core/submission/submission-scope-type';
import { FormBuilderService } from '../../../shared/form/builder/form-builder.service'; import { FormBuilderService } from '../../../shared/form/builder/form-builder.service';
import { FormService } from '../../../shared/form/form.service'; import { FormService } from '../../../shared/form/form.service';
import { getMockFormBuilderService } from '../../../shared/mocks/form-builder-service.mock';
import { getMockFormOperationsService } from '../../../shared/mocks/form-operations-service.mock'; import { getMockFormOperationsService } from '../../../shared/mocks/form-operations-service.mock';
import { getMockFormService } from '../../../shared/mocks/form-service.mock'; import { getMockFormService } from '../../../shared/mocks/form-service.mock';
import { import {
@@ -168,7 +169,7 @@ describe('SubmissionSectionDuplicatesComponent test suite', () => {
{ provide: 'submissionIdProvider', useValue: submissionId }, { provide: 'submissionIdProvider', useValue: submissionId },
{ provide: PaginationService, useValue: paginationService }, { provide: PaginationService, useValue: paginationService },
ChangeDetectorRef, ChangeDetectorRef,
FormBuilderService, { provide: FormBuilderService, useValue: getMockFormBuilderService() },
], ],
schemas: [NO_ERRORS_SCHEMA], schemas: [NO_ERRORS_SCHEMA],
}).compileComponents().then(); }).compileComponents().then();

View File

@@ -1,5 +1,6 @@
import { SubmissionSectionAccessesComponent } from './accesses/section-accesses.component'; import { SubmissionSectionAccessesComponent } from './accesses/section-accesses.component';
import { SubmissionSectionCcLicensesComponent } from './cc-license/submission-section-cc-licenses.component'; import { SubmissionSectionCcLicensesComponent } from './cc-license/submission-section-cc-licenses.component';
import { SubmissionSectionDuplicatesComponent } from './duplicates/section-duplicates.component';
import { SubmissionSectionFormComponent } from './form/section-form.component'; import { SubmissionSectionFormComponent } from './form/section-form.component';
import { SubmissionSectionIdentifiersComponent } from './identifiers/section-identifiers.component'; import { SubmissionSectionIdentifiersComponent } from './identifiers/section-identifiers.component';
import { SubmissionSectionLicenseComponent } from './license/section-license.component'; import { SubmissionSectionLicenseComponent } from './license/section-license.component';
@@ -7,7 +8,6 @@ import { SubmissionSectionCoarNotifyComponent } from './section-coar-notify/sect
import { SectionsType } from './sections-type'; import { SectionsType } from './sections-type';
import { SubmissionSectionSherpaPoliciesComponent } from './sherpa-policies/section-sherpa-policies.component'; import { SubmissionSectionSherpaPoliciesComponent } from './sherpa-policies/section-sherpa-policies.component';
import { SubmissionSectionUploadComponent } from './upload/section-upload.component'; import { SubmissionSectionUploadComponent } from './upload/section-upload.component';
import { SubmissionSectionDuplicatesComponent } from './duplicates/section-duplicates.component';
const submissionSectionsMap = new Map(); const submissionSectionsMap = new Map();