hazza/yel-dspace-angular
1
0
Fork 0
forked from hazza/dspace-angular
Code Pull Requests Activity

Manual fix: sync removed imports between tests and components

Browse Source 
The automatic migration made it so HTML always uses the `Themed*` component, and it must therefore be imported in all standalone components that use it.
Afterwards, many unit tests fail because the removed imports no longer match up (can't inject `ThemeService`).

While we could try to support this as part of the automatic migration, there are too many edge cases for this to be consistent.
This commit is contained in:
Yury Bondarenko
2024-03-28 18:43:43 +01:00
parent 0b9741d252
commit 762e4616cc
20 changed files with 34 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/notifications/qa/topics/quality-assurance-topics.component.spec.ts
View File

@@ -18,7 +18,7 @@ import { ItemDataService } from 'src/app/core/data/item-data.service';
import { PaginationService } from '../../../core/pagination/pagination.service';
import { AlertComponent } from '../../../shared/alert/alert.component';
import { LoadingComponent } from '../../../shared/loading/loading.component';
import { ThemedLoadingComponent } from '../../../shared/loading/themed-loading.component';
import {
getMockNotificationsStateService,
qualityAssuranceTopicObjectMoreAbstract,
@@ -69,7 +69,7 @@ describe('QualityAssuranceTopicsComponent test suite', () => {
remove: {
imports: [
AlertComponent,
LoadingComponent,
ThemedLoadingComponent,
PaginationComponent,
],
},