hazza/yel-dspace-angular
1
0
Fork 0
forked from hazza/dspace-angular
Code Pull Requests Activity

93803: Update DataService constructor signatures

Browse Source 
Override linkPath/responseMsToLive/constructIdEndpoint
  - in class body for inheritable classes (for clarity: it's the first thing you'd read, variable name is right there)
  - in constructor for composable classes
    * wrapped services must be 'synchronized' with their wrapper
    * moved these overrides up in the argument list for emphasis (implementing a new composable feature? first thing is to use the same endpoint!)
This commit is contained in:
Yura Bondarenko
2022-09-05 10:55:58 +02:00
parent 38203490c7
commit a6fb4a6303
70 changed files with 294 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/core/data/base/create-data.ts
View File

@@ -45,14 +45,14 @@ export interface CreateData<T extends CacheableObject> {
export class CreateDataImpl<T extends CacheableObject> extends BaseDataService<T> implements CreateData<T> {
constructor(
protected linkPath: string,
protected responseMsToLive: number,
protected requestService: RequestService,
protected rdbService: RemoteDataBuildService,
protected objectCache: ObjectCacheService,
protected halService: HALEndpointService,
protected notificationsService: NotificationsService,
protected responseMsToLive: number,
) {
super(linkPath, requestService, rdbService, objectCache, halService, responseMsToLive);
super(requestService, rdbService, objectCache, halService, linkPath, responseMsToLive);
}
/**