diff --git a/src/app/submission/objects/submission-objects.effects.spec.ts b/src/app/submission/objects/submission-objects.effects.spec.ts index b2bc054287..69ee74224e 100644 --- a/src/app/submission/objects/submission-objects.effects.spec.ts +++ b/src/app/submission/objects/submission-objects.effects.spec.ts @@ -884,6 +884,7 @@ describe('SubmissionObjectEffects test suite', () => { }); expect(submissionObjectEffects.saveAndDeposit$).toBeObservable(expected); + expect(notificationsServiceStub.warning).not.toHaveBeenCalled(); }); it('should return a SAVE_SUBMISSION_FORM_SUCCESS action when there are errors', () => { @@ -910,10 +911,11 @@ describe('SubmissionObjectEffects test suite', () => { submissionJsonPatchOperationsServiceStub.jsonPatchByResourceType.and.returnValue(observableOf(response)); const expected = cold('--b-', { - b: new SaveSubmissionFormSuccessAction(submissionId, response as any[]) + b: new SaveSubmissionFormSuccessAction(submissionId, response as any[], false) }); expect(submissionObjectEffects.saveAndDeposit$).toBeObservable(expected); + expect(notificationsServiceStub.warning).toHaveBeenCalled(); }); it('should catch errors and return a SAVE_SUBMISSION_FORM_ERROR', () => { diff --git a/src/app/submission/objects/submission-objects.effects.ts b/src/app/submission/objects/submission-objects.effects.ts index 52e20ee149..8d53fedbf9 100644 --- a/src/app/submission/objects/submission-objects.effects.ts +++ b/src/app/submission/objects/submission-objects.effects.ts @@ -215,7 +215,13 @@ export class SubmissionObjectEffects { if (this.canDeposit(response)) { return new DepositSubmissionAction(action.payload.submissionId); } else { - return new SaveSubmissionFormSuccessAction(action.payload.submissionId, response); + this.notificationsService.warning( + null, + this.translate.instant('submission.sections.general.cannot_deposit'), + null, + true + ); + return new SaveSubmissionFormSuccessAction(action.payload.submissionId, response, false); } }), catchError(() => observableOf(new SaveSubmissionFormErrorAction(action.payload.submissionId)))); diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5 index c3c68a6882..a698fab641 100644 --- a/src/assets/i18n/en.json5 +++ b/src/assets/i18n/en.json5 @@ -3828,6 +3828,8 @@ "submission.sections.general.add-more": "Add more", + "submission.sections.general.cannot_deposit": "Deposit cannot be completed due to missing mandatory information.
Please add them for final submission.", + "submission.sections.general.collection": "Collection", "submission.sections.general.deposit_error_notice": "There was an issue when submitting the item, please try again later.",