Merge branch 'CST-5337' into CST-5249_suggestion

src/app/admin/admin-notifications/admin-quality-assurance-events-page/admin-quality-assurance-events-page.component.ts

@@ -1,5 +1,8 @@
 import { Component } from '@angular/core';
 
+/**
+ * Component for the page that show the QA events related to a specific topic.
+ */
 @Component({
   selector: 'ds-quality-assurance-events-page',
   templateUrl: './admin-quality-assurance-events-page.component.html'

src/app/admin/admin-notifications/admin-quality-assurance-source-page-component/admin-quality-assurance-source-page.component.ts

@@ -1,5 +1,8 @@
 import { Component, OnInit } from '@angular/core';
 
+/**
+ * Component for the page that show the QA sources.
+ */
 @Component({
   selector: 'ds-admin-quality-assurance-source-page-component',
   templateUrl: './admin-quality-assurance-source-page.component.html',

src/app/admin/admin-notifications/admin-quality-assurance-topics-page/admin-quality-assurance-topics-page.component.ts

@@ -1,5 +1,8 @@
 import { Component } from '@angular/core';
 
+/**
+ * Component for the page that show the QA topics related to a specific source.
+ */
 @Component({
   selector: 'ds-notification-qa-page',
   templateUrl: './admin-quality-assurance-topics-page.component.html'

src/app/core/suggestion-notifications/qa/models/quality-assurance-event.model.ts

@@ -73,6 +73,11 @@ export interface OpenaireQualityAssuranceEventMessageObject {
    */
   openaireId: string;
 
+  /**
+   * The PID href.
+   */
+  pidHref: string;
+
 }
 
 /**

src/app/shared/mocks/notifications.mock.ts

@@ -1464,6 +1464,7 @@ export const qualityAssuranceEventObjectMissingPid: QualityAssuranceEventObject
   message: {
     type: 'doi',
     value: '10.18848/1447-9494/cgp/v15i09/45934',
+    pidHref: 'https://doi.org/10.18848/1447-9494/cgp/v15i09/45934',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1500,6 +1501,7 @@ export const qualityAssuranceEventObjectMissingPid2: QualityAssuranceEventObject
   message: {
     type: 'urn',
     value: 'http://thesis2.sba.units.it/store/handle/item/12238',
+    pidHref:'http://thesis2.sba.units.it/store/handle/item/12238',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1536,6 +1538,7 @@ export const qualityAssuranceEventObjectMissingPid3: QualityAssuranceEventObject
   message: {
     type: 'doi',
     value: '10.4324/9780203408889',
+    pidHref: 'https://doi.org/10.4324/9780203408889',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1572,6 +1575,7 @@ export const qualityAssuranceEventObjectMissingPid4: QualityAssuranceEventObject
   message: {
     type: 'doi',
     value: '10.1080/13698230.2018.1430104',
+    pidHref: 'https://doi.org/10.1080/13698230.2018.1430104',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1608,6 +1612,7 @@ export const qualityAssuranceEventObjectMissingPid5: QualityAssuranceEventObject
   message: {
     type: 'urn',
     value: 'http://thesis2.sba.units.it/store/handle/item/12477',
+    pidHref:'http://thesis2.sba.units.it/store/handle/item/12477',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1644,6 +1649,7 @@ export const qualityAssuranceEventObjectMissingPid6: QualityAssuranceEventObject
   message: {
     type: 'doi',
     value: '10.1111/j.1475-4975.2004.00098.x',
+    pidHref: 'https://doi.org/10.1111/j.1475-4975.2004.00098.x',
     abstract: null,
     openaireId: null,
     acronym: null,
@@ -1680,6 +1686,7 @@ export const qualityAssuranceEventObjectMissingAbstract: QualityAssuranceEventOb
   message: {
     type: null,
     value: null,
+    pidHref: null,
     abstract: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla scelerisque vestibulum tellus sed lacinia. Aenean vitae sapien a quam congue ultrices. Sed vehicula sollicitudin ligula, vitae lacinia velit. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla scelerisque vestibulum tellus sed lacinia. Aenean vitae sapien a quam congue ultrices. Sed vehicula sollicitudin ligula, vitae lacinia velit.',
     openaireId: null,
     acronym: null,
@@ -1716,6 +1723,7 @@ export const qualityAssuranceEventObjectMissingProjectFound: QualityAssuranceEve
   message: {
     type: null,
     value: null,
+    pidHref: null,
     abstract: null,
     openaireId: null,
     acronym: 'PAThs',
@@ -1752,6 +1760,7 @@ export const qualityAssuranceEventObjectMissingProjectNotFound: QualityAssurance
   message: {
     type: null,
     value: null,
+    pidHref: null,
     abstract: null,
     openaireId: null,
     acronym: 'PAThs',

src/app/suggestion-notifications/qa/events/quality-assurance-events.component.ts

@@ -38,7 +38,7 @@ import { FindListOptions } from '../../../core/data/find-list-options.model';
 @Component({
   selector: 'ds-quality-assurance-events',
   templateUrl: './quality-assurance-events.component.html',
-  styleUrls: ['./quality-assurance-events.scomponent.scss'],
+  styleUrls: ['./quality-assurance-events.component.scss'],
 })
 export class QualityAssuranceEventsComponent implements OnInit, OnDestroy {
   /**
@@ -334,7 +334,7 @@ export class QualityAssuranceEventsComponent implements OnInit, OnDestroy {
    * @param event
    */
   public getPIDHref(event: OpenaireQualityAssuranceEventMessageObject): string {
-    return this.computePIDHref(event);
+    return event.pidHref;
   }
 
 
@@ -423,47 +423,4 @@ export class QualityAssuranceEventsComponent implements OnInit, OnDestroy {
       );
     }
   }
-
-  protected computePIDHref(event: OpenaireQualityAssuranceEventMessageObject) {
-    const type = event.type.toLowerCase();
-    const pid = event.value;
-    let prefix = null;
-    switch (type) {
-      case 'arxiv': {
-        prefix = 'https://arxiv.org/abs/';
-        break;
-      }
-      case 'handle': {
-        prefix = 'https://hdl.handle.net/';
-        break;
-      }
-      case 'urn': {
-        prefix = '';
-        break;
-      }
-      case 'doi': {
-        prefix = 'https://doi.org/';
-        break;
-      }
-      case 'pmc': {
-        prefix = 'https://www.ncbi.nlm.nih.gov/pmc/articles/';
-        break;
-      }
-      case 'pmid': {
-        prefix = 'https://pubmed.ncbi.nlm.nih.gov/';
-        break;
-      }
-      case 'ncid': {
-        prefix = 'https://ci.nii.ac.jp/ncid/';
-        break;
-      }
-      default: {
-        break;
-      }
-    }
-    if (prefix === null) {
-      return null;
-    }
-    return prefix + pid;
-  }
 }

src/app/suggestion-notifications/qa/source/quality-assurance-source.component.ts

@@ -9,6 +9,9 @@ import { SuggestionNotificationsStateService } from '../../suggestion-notificati
 import { AdminQualityAssuranceSourcePageParams } from '../../../admin/admin-notifications/admin-quality-assurance-source-page-component/admin-quality-assurance-source-page-resolver.service';
 import { hasValue } from '../../../shared/empty.util';
 
+/**
+ * Component to display the Quality Assurance source list.
+ */
 @Component({
   selector: 'ds-quality-assurance-source',
   templateUrl: './quality-assurance-source.component.html',