Merge pull request #8117 from atmire/w2p-85525_pr-fix-qdccrosswalk-test

Refactor QDCCrosswalkTest to avoid config errors
This commit is contained in:
Tim Donohue
2022-01-20 11:00:26 -06:00
committed by GitHub
2 changed files with 12 additions and 2 deletions

View File

@@ -129,7 +129,7 @@ public class QDCCrosswalk extends SelfNamedPlugin
protected ItemService itemService = ContentServiceFactory.getInstance().getItemService();
protected static final ConfigurationService configurationService
protected final ConfigurationService configurationService
= DSpaceServicesFactory.getInstance().getConfigurationService();
private final CrosswalkMetadataValidator metadataValidator = new CrosswalkMetadataValidator();
@@ -141,9 +141,17 @@ public class QDCCrosswalk extends SelfNamedPlugin
private static String aliases[] = null;
static {
initStatic();
}
/**
* Call this method again in tests to repeat initialization if necessary.
*/
public static void initStatic() {
List<String> aliasList = new ArrayList<>();
String propname = CONFIG_PREFIX + ".properties.";
List<String> configKeys = configurationService.getPropertyKeys(propname);
List<String> configKeys =
DSpaceServicesFactory.getInstance().getConfigurationService().getPropertyKeys(propname);
for (String key : configKeys) {
aliasList.add(key.substring(propname.length()));
}

View File

@@ -76,6 +76,8 @@ public class QDCCrosswalkTest
@Before
public void setUp() {
// make sure that the config properties set in @BeforeClass are picked up
QDCCrosswalk.initStatic();
}
@After