hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-07 01:54:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CST-12108] remove creationForm attribute as not needed

Browse Source
This commit is contained in:
Mykhaylo Boychuk
2024-02-20 22:50:04 +01:00
parent 4212ca4e07
commit 36bfe58060
4 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/CorrectionTypeConverter.java
View File

@@ -27,7 +27,6 @@ public class CorrectionTypeConverter implements DSpaceConverter<CorrectionType,
targetRest.setProjection(projection);
targetRest.setId(target.getId());
targetRest.setTopic(target.getTopic());
targetRest.setCreationForm(target.getCreationForm());
return targetRest;
}

9
dspace-server-webapp/src/main/java/org/dspace/app/rest/model/CorrectionTypeRest.java
View File

@@ -23,7 +23,6 @@ public class CorrectionTypeRest extends BaseObjectRest<String> {
public static final String CATEGORY = RestAddressableModel.CONFIGURATION;
private String topic;
private String creationForm;
public String getTopic() {
return topic;
@@ -33,14 +32,6 @@ public class CorrectionTypeRest extends BaseObjectRest<String> {
this.topic = topic;
}
public String getCreationForm() {
return creationForm;
}
public void setCreationForm(String creationForm) {
this.creationForm = creationForm;
}
@Override
public String getCategory() {
return CATEGORY;

9
dspace-server-webapp/src/test/java/org/dspace/app/rest/CorrectionTypeRestRepositoryIT.java
View File

@@ -52,7 +52,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
allOf(
hasJsonPath("$.id", equalTo("request-withdrawn")),
hasJsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")),
hasJsonPath("$.creationForm", equalTo("provideReason")),
hasJsonPath("$.type", equalTo("correctiontype"))
),
allOf(
@@ -73,7 +72,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
allOf(
hasJsonPath("$.id", equalTo("request-withdrawn")),
hasJsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")),
hasJsonPath("$.creationForm", equalTo("provideReason")),
hasJsonPath("$.type", equalTo("correctiontype"))
),
allOf(
@@ -97,7 +95,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
.andExpect(status().isOk())
.andExpect(jsonPath("$.id", equalTo("request-withdrawn")))
.andExpect(jsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")))
.andExpect(jsonPath("$.creationForm", equalTo("provideReason")))
.andExpect(jsonPath("$.type", equalTo("correctiontype")));
}
@@ -108,7 +105,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
.andExpect(status().isOk())
.andExpect(jsonPath("$.id", equalTo("request-withdrawn")))
.andExpect(jsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")))
.andExpect(jsonPath("$.creationForm", equalTo("provideReason")))
.andExpect(jsonPath("$.type", equalTo("correctiontype")));
}
@@ -213,7 +209,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
allOf(
hasJsonPath("$.id", equalTo("request-withdrawn")),
hasJsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")),
hasJsonPath("$.creationForm", equalTo("provideReason")),
hasJsonPath("$.type", equalTo("correctiontype"))
)
)));
@@ -238,7 +233,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
allOf(
hasJsonPath("$.id", equalTo("request-withdrawn")),
hasJsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")),
hasJsonPath("$.creationForm", equalTo("provideReason")),
hasJsonPath("$.type", equalTo("correctiontype"))
)
)));
@@ -262,7 +256,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
allOf(
hasJsonPath("$.id", equalTo("request-withdrawn")),
hasJsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")),
hasJsonPath("$.creationForm", equalTo("provideReason")),
hasJsonPath("$.type", equalTo("correctiontype"))
)
)));
@@ -291,7 +284,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
.andExpect(status().isOk())
.andExpect(jsonPath("$.id", equalTo("request-withdrawn")))
.andExpect(jsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")))
.andExpect(jsonPath("$.creationForm", equalTo("provideReason")))
.andExpect(jsonPath("$.type", equalTo("correctiontype")));
}
@@ -303,7 +295,6 @@ public class CorrectionTypeRestRepositoryIT extends AbstractControllerIntegratio
.andExpect(status().isOk())
.andExpect(jsonPath("$.id", equalTo("request-withdrawn")))
.andExpect(jsonPath("$.topic", equalTo("REQUEST/WITHDRAWN")))
.andExpect(jsonPath("$.creationForm", equalTo("provideReason")))
.andExpect(jsonPath("$.type", equalTo("correctiontype")));
}

1
dspace/config/spring/api/correction-types.xml
View File

@@ -7,7 +7,6 @@
<bean id="withdrawnRequest" class="org.dspace.correctiontype.WithdrawnCorrectionType" >
<property name="id" value="request-withdrawn"/>
<property name="topic" value="REQUEST/WITHDRAWN"/>
<property name="creationForm" value="provideReason"/>
</bean>
<bean id="reinstateRequest" class="org.dspace.correctiontype.ReinstateCorrectionType" >