hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-07 01:54:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11244 from DSpace/backport-11195-to-dspace-9_x

Browse Source 
[Port dspace-9_x] Implement logging for index out-of-range in MetadataValueRemovePatchOperation
This commit is contained in:
Tim Donohue
2025-09-02 15:10:40 -05:00
committed by GitHub
parent f1386c2c25 4829647345
commit 5b12a5d0b7
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
dspace-server-webapp/src/main/java/org/dspace/app/rest/submit/factory/impl/MetadataValueRemovePatchOperation.java
View File

@@ -11,6 +11,8 @@ import java.sql.SQLException;
import java.util.Arrays;
import java.util.List;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.dspace.app.rest.model.MetadataValueRest;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
@@ -27,6 +29,8 @@ import org.dspace.core.Utils;
public abstract class MetadataValueRemovePatchOperation<DSO extends DSpaceObject>
extends RemovePatchOperation<MetadataValueRest> {
private static final Logger log = LogManager.getLogger();
@Override
protected Class<MetadataValueRest[]> getArrayClassForEvaluation() {
return MetadataValueRest[].class;
@@ -42,7 +46,12 @@ public abstract class MetadataValueRemovePatchOperation<DSO extends DSpaceObject
List<MetadataValue> mm = getDSpaceObjectService().getMetadata(source, metadata[0], metadata[1], metadata[2],
Item.ANY);
if (index != -1) {
getDSpaceObjectService().removeMetadataValues(context, source, Arrays.asList(mm.get(index)));
if (index < mm.size()) {
getDSpaceObjectService().removeMetadataValues(context, source, Arrays.asList(mm.get(index)));
} else {
log.warn("value of index ({}) is out of range of the metadata value list of size {} (target: {})",
index, mm.size(), target);
}
} else {
getDSpaceObjectService().clearMetadata(context, source, metadata[0], metadata[1], metadata[2], Item.ANY);
}