[DURACOM-116] moved sorting to service

This commit is contained in:
corrado lombardi
2023-02-13 12:53:13 +01:00
parent 1fcbd6642c
commit a37403781e
2 changed files with 5 additions and 6 deletions

View File

@@ -8,6 +8,7 @@
package org.dspace.scripts;
import java.lang.reflect.InvocationTargetException;
import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;
@@ -36,7 +37,9 @@ public class ScriptServiceImpl implements ScriptService {
@Override
public List<ScriptConfiguration> getScriptConfigurations(Context context) {
return serviceManager.getServicesByType(ScriptConfiguration.class).stream().filter(
scriptConfiguration -> scriptConfiguration.isAllowedToExecute(context)).collect(Collectors.toList());
scriptConfiguration -> scriptConfiguration.isAllowedToExecute(context))
.sorted(Comparator.comparing(ScriptConfiguration::getName))
.collect(Collectors.toList());
}
@Override

View File

@@ -11,7 +11,6 @@ import java.io.IOException;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
@@ -82,10 +81,7 @@ public class ScriptRestRepository extends DSpaceRestRepository<ScriptRest, Strin
@PreAuthorize("hasAuthority('ADMIN')")
public Page<ScriptRest> findAll(Context context, Pageable pageable) {
List<ScriptConfiguration> scriptConfigurations =
scriptService.getScriptConfigurations(context)
.stream()
.sorted(Comparator.comparing(ScriptConfiguration::getName))
.collect(Collectors.toList());
scriptService.getScriptConfigurations(context);
return converter.toRestPage(scriptConfigurations, pageable, utils.obtainProjection());
}