hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-07 01:54:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

use equals instead of ==

Browse Source 
(cherry picked from commit d2ef7b01ef)
This commit is contained in:
Sascha Szott
2024-08-02 17:48:28 +02:00
committed by github-actions[bot]
parent 7b08fdfe9e
commit f0ea00b5cd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dspace-api/src/main/java/org/dspace/eperson/GroupServiceImpl.java
View File

@@ -147,7 +147,7 @@ public class GroupServiceImpl extends DSpaceObjectServiceImpl<Group> implements
public void addMember(Context context, Group groupParent, Group groupChild) throws SQLException {
// don't add if it's already a member
// and don't add itself
if (groupParent.contains(groupChild) || groupParent.getID() == groupChild.getID()) {
if (groupParent.contains(groupChild) || groupParent.getID().equals(groupChild.getID())) {
return;
}
@@ -178,7 +178,7 @@ public class GroupServiceImpl extends DSpaceObjectServiceImpl<Group> implements
Role role = stepByName.getRole();
for (CollectionRole collectionRole : collectionRoles) {
if (StringUtils.equals(collectionRole.getRoleId(), role.getId())
&& claimedTask.getWorkflowItem().getCollection() == collectionRole.getCollection()) {
&& claimedTask.getWorkflowItem().getCollection().equals(collectionRole.getCollection())) {
// Count number of EPersons who are *direct* members of this group
int totalDirectEPersons = ePersonService.countByGroups(context, Set.of(group));
// Count number of Groups which have this groupParent as a direct parent