(Larry Stone)

- Added a sanity check to ensure that bad or corrupted file names to not retrieve an unintended file.


git-svn-id: http://scm.dspace.org/svn/repo/trunk@1526 9c30dcfa-912a-0410-8fc2-9e0234be79fd

dspace/src/org/dspace/storage/bitstore/BitstreamStorageManager.java

@@ -788,6 +788,15 @@ public class BitstreamStorageManager
 			sInternalId = sInternalId.substring(REGISTERED_FLAG.length());
 			sIntermediatePath = "";
 		} else {
+			
+			// Sanity Check: If the internal ID contains a
+			// pathname separator, it's probably an attempt to
+			// make a path traversal attack, so ignore the path
+			// prefix.  The internal-ID is supposed to be just a
+			// filename, so this will not affect normal operation.
+			if (sInternalId.indexOf(File.separator) != -1)
+				sInternalId = sInternalId.substring(sInternalId.lastIndexOf(File.separator)+1);
+			
 			sIntermediatePath = getIntermediatePath(sInternalId);
 		}