Merge pull request #601 from romainneutron/fix-1430

[3.8] Use strict standards for task::getName method

lib/classes/task/abstract.php

@@ -393,9 +393,15 @@ abstract class task_abstract
         return $this->completed_percentage;
     }
 
-    abstract public function getName();
+    public static function getName()
+    {
+        throw new \LogicException('This method must be implemented');
+    }
 
-    abstract public function help();
+    public static function help()
+    {
+        throw new \LogicException('This method must be implemented');
+    }
 
     /**
      *

lib/classes/task/period/RecordMover.php

@@ -16,7 +16,7 @@ class task_period_RecordMover extends task_appboxAbstract
      *
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return _("Record Mover");
     }
@@ -25,7 +25,7 @@ class task_period_RecordMover extends task_appboxAbstract
      *
      * @return string
      */
-    public function help()
+    public static function help()
     {
         return '';
     }

lib/classes/task/period/apibridge.php

@@ -16,7 +16,7 @@ class task_period_apibridge extends task_appboxAbstract
      * Return the name of the task
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return 'API bridge uploader';
     }
@@ -25,7 +25,7 @@ class task_period_apibridge extends task_appboxAbstract
      * Get help
      * @return string
      */
-    public function help()
+    public static function help()
     {
         return '';
     }

lib/classes/task/period/archive.php

@@ -64,7 +64,7 @@ class task_period_archive extends task_abstract
      *
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return _('task::archive:Archivage');
     }
@@ -284,7 +284,7 @@ class task_period_archive extends task_abstract
      *
      * @return string
      */
-    public function help()
+    public static function help()
     {
         return _("task::archive:Archiving files found into a 'hotfolder'");
     }

lib/classes/task/period/cindexer.php

@@ -99,7 +99,7 @@ class task_period_cindexer extends task_abstract
      *
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return(_("Indexation task"));
     }
@@ -108,7 +108,7 @@ class task_period_cindexer extends task_abstract
      *
      * @return string
      */
-    public function help()
+    public static function help()
     {
         return(_("This task is used to index records for Phrasea engine."));
     }

lib/classes/task/period/emptyColl.php

@@ -17,7 +17,7 @@ class task_period_emptyColl extends task_appboxAbstract
     protected $suicidable = true;
     protected $total_records = 0;
 
-    public function getName()
+    public static function getName()
     {
         return(_("Vidage de collection"));
     }
@@ -27,7 +27,7 @@ class task_period_emptyColl extends task_appboxAbstract
         return false;
     }
 
-    public function help()
+    public static function help()
     {
         return("Vide une collection");
     }

lib/classes/task/period/ftp.php

@@ -22,7 +22,7 @@ class task_period_ftp extends task_appboxAbstract
      *
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return(_("task::ftp:FTP Push"));
     }
@@ -31,7 +31,7 @@ class task_period_ftp extends task_appboxAbstract
      *
      * @return string
      */
-    public function help()
+    public static function help()
     {
         return '';
     }

lib/classes/task/period/ftpPull.php

@@ -23,12 +23,12 @@ class task_period_ftpPull extends task_appboxAbstract
     protected $ftppath;
     protected $localpath;
 
-    public function getName()
+    public static function getName()
     {
         return(_("task::ftp:FTP Pull"));
     }
 
-    public function help()
+    public static function help()
     {
         return '';
     }

lib/classes/task/period/subdef.php

@@ -41,7 +41,7 @@ class task_period_subdef extends task_databoxAbstract
      *
      * @return <type>
      */
-    public function help()
+    public static function help()
     {
         return(
             _("task::subdef:creation des sous definitions des documents d'origine")
@@ -53,7 +53,7 @@ class task_period_subdef extends task_databoxAbstract
      *
      * @return string
      */
-    public function getName()
+    public static function getName()
     {
         return(_('task::subdef:creation des sous definitions'));
     }

lib/classes/task/period/test.php

@@ -12,12 +12,12 @@
 class task_period_test extends task_appboxAbstract
 {
 
-    public function getName()
+    public static function getName()
     {
         return "Test";
     }
 
-    public function help()
+    public static function help()
     {
         return "just saying what i'm doing";
     }

lib/classes/task/period/writemeta.php

@@ -19,7 +19,7 @@ class task_period_writemeta extends task_databoxAbstract
     protected $clear_doc;
     protected $metasubdefs = array();
 
-    public function help()
+    public static function help()
     {
         return(_("task::writemeta:(re)ecriture des metadatas dans les documents (et subdefs concernees)"));
     }
@@ -30,7 +30,7 @@ class task_period_writemeta extends task_databoxAbstract
         parent::loadSettings($sx_task_settings);
     }
 
-    public function getName()
+    public static function getName()
     {
         return(_('task::writemeta:ecriture des metadatas'));
     }