Fix more errors

This commit is contained in:
Ayaz Salikhov
2021-05-01 13:09:26 +03:00
parent c2031e2a4a
commit 09db3a4c16
5 changed files with 10 additions and 0 deletions

View File

@@ -28,3 +28,4 @@ repos:
rev: v0.27.1 rev: v0.27.1
hooks: hooks:
- id: markdownlint - id: markdownlint
args: ['--fix']

View File

@@ -40,9 +40,11 @@ If there's agreement that the feature belongs in one or more of the core stacks:
2. Please build the image locally before submitting a pull request. Building the image locally 2. Please build the image locally before submitting a pull request. Building the image locally
shortens the debugging cycle by taking some load off GitHub Actions, which graciously provide shortens the debugging cycle by taking some load off GitHub Actions, which graciously provide
free build services for open source projects like this one. If you use `make`, call: free build services for open source projects like this one. If you use `make`, call:
```bash ```bash
make build/somestack-notebook make build/somestack-notebook
``` ```
3. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request) 3. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request)
(PR) with your changes. (PR) with your changes.
4. Watch for GitHub to report a build success or failure for your PR on GitHub. 4. Watch for GitHub to report a build success or failure for your PR on GitHub.

View File

@@ -16,9 +16,11 @@ Please follow the process below to update a package version:
3. Please build the image locally before submitting a pull request. Building the image locally 3. Please build the image locally before submitting a pull request. Building the image locally
shortens the debugging cycle by taking some load off GitHub Actions, which graciously provide shortens the debugging cycle by taking some load off GitHub Actions, which graciously provide
free build services for open source projects like this one. If you use `make`, call: free build services for open source projects like this one. If you use `make`, call:
```bash ```bash
make build/somestack-notebook make build/somestack-notebook
``` ```
4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request) 4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request)
(PR) with your changes. (PR) with your changes.
5. Watch for GitHub to report a build success or failure for your PR on GitHub. 5. Watch for GitHub to report a build success or failure for your PR on GitHub.

View File

@@ -23,10 +23,12 @@ Please follow the process below to add new tests:
2. If your test should run against a single image, add your test code to one of the modules in 2. If your test should run against a single image, add your test code to one of the modules in
`some-notebook/test/` or create a new module. `some-notebook/test/` or create a new module.
3. Build one or more images you intend to test and run the tests locally. If you use `make`, call: 3. Build one or more images you intend to test and run the tests locally. If you use `make`, call:
```bash ```bash
make build/somestack-notebook make build/somestack-notebook
make test/somestack-notebook make test/somestack-notebook
``` ```
4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request) 4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request)
(PR) with your changes. (PR) with your changes.
5. Watch for GitHub to report a build success or failure for your PR on GitHub. 5. Watch for GitHub to report a build success or failure for your PR on GitHub.

View File

@@ -166,11 +166,13 @@ ENTRYPOINT ["jupyter", "lab", "--ip=0.0.0.0", "--allow-root"]
``` ```
And build the image as: And build the image as:
```bash ```bash
docker build -t jupyter/scipy-dasklabextension:latest . docker build -t jupyter/scipy-dasklabextension:latest .
``` ```
Once built, run using the command: Once built, run using the command:
```bash ```bash
docker run -it --rm -p 8888:8888 -p 8787:8787 jupyter/scipy-dasklabextension:latest docker run -it --rm -p 8888:8888 -p 8787:8787 jupyter/scipy-dasklabextension:latest
``` ```
@@ -273,6 +275,7 @@ ARG BASE_CONTAINER=ubuntu:focal-20200423@sha256:238e696992ba9913d24cfc3727034985
``` ```
For Ubuntu 18.04 (bionic) and earlier, you may also require to workaround for a mandb bug, which was fixed in mandb >= 2.8.6.1: For Ubuntu 18.04 (bionic) and earlier, you may also require to workaround for a mandb bug, which was fixed in mandb >= 2.8.6.1:
```dockerfile ```dockerfile
# https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=8197d7824f814c5d4b992b4c8730b5b0f7ec589a # https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=8197d7824f814c5d4b992b4c8730b5b0f7ec589a
# http://launchpadlibrarian.net/435841763/man-db_2.8.5-2_2.8.6-1.diff.gz # http://launchpadlibrarian.net/435841763/man-db_2.8.5-2_2.8.6-1.diff.gz