hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-08 02:24:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
09db3a4c16d9947f2807575d3149721bb2b0cbb7
docker-stacks/docs/contributing/tests.md
Ayaz Salikhov 09db3a4c16 Fix more errors
2021-05-01 13:09:26 +03:00

1.8 KiB
Raw Blame History

Image Tests

We greatly appreciate pull requests that extend the automated tests that vet the basic functionality of the Docker images.

How the Tests Work

GitHub executes make build-test-all against pull requests submitted to the jupyter/docker-stacks repository. This make command builds every docker image. After building each image, the make command executes pytest to run both image-specific tests like those in base-notebook/test/ and common tests defined in test/. Both kinds of tests make use of global pytest fixtures defined in the conftest.py file at the root of the projects.

Contributing New Tests

Please follow the process below to add new tests:

  1. If the test should run against every image built, add your test code to one of the modules in test/ or create a new module.

  2. If your test should run against a single image, add your test code to one of the modules in some-notebook/test/ or create a new module.

  3. Build one or more images you intend to test and run the tests locally. If you use make, call:

    make build/somestack-notebook
make test/somestack-notebook

  4. Submit a pull request (PR) with your changes.

  5. Watch for GitHub to report a build success or failure for your PR on GitHub.

  6. Discuss changes with the maintainers and address any issues running the tests on GitHub.