hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-11 03:52:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
This commit is contained in:
Ayaz Salikhov
2022-05-18 19:30:39 +03:00
committed by GitHub
parent 927cbf8cfb
commit 1936d7356a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/docker-tag-manifest-push.yml vendored
View File

@@ -1,4 +1,4 @@
name: Download image artifact from GitHub artifacts, tag it and push to DockerHub name: Download Docker image from GitHub artifacts, tag and push it to DockerHub
on: on:
workflow_call: workflow_call:
@@ -30,7 +30,7 @@ jobs:
- name: Create dev environment 📦 - name: Create dev environment 📦
uses: ./.github/actions/create-dev-env uses: ./.github/actions/create-dev-env
- name: Load image to docker 📥 - name: Load image to Docker 📥
uses: ./.github/actions/load-image uses: ./.github/actions/load-image
with: with:
image: ${{ matrix.image }} image: ${{ matrix.image }}

2
docs/contributing/tests.md
View File

@@ -5,7 +5,7 @@ We greatly appreciate pull requests that extend the automated tests that vet the
## How the Tests Work ## How the Tests Work
A [GitHub Action workflow](https://github.com/jupyter/docker-stacks/blob/master/.github/workflows/docker.yml) A [GitHub Action workflow](https://github.com/jupyter/docker-stacks/blob/master/.github/workflows/docker.yml)
runs tests against pull requests submitted to the `jupyter/docker-stacks` repository: runs tests against pull requests submitted to the `jupyter/docker-stacks` repository.
We use `pytest` module to run tests on the image. We use `pytest` module to run tests on the image.
`conftest.py` and `pytest.ini` in the `tests` folder define the environment in which tests are run. `conftest.py` and `pytest.ini` in the `tests` folder define the environment in which tests are run.