hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-08 18:44:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove JUPYTER_ENABLE_LAB variable warning

Browse Source
This commit is contained in:
Ayaz Salikhov
2022-04-01 00:23:17 +01:00
parent 9d68c7d1d4
commit c1a892c6dc
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
base-notebook/start-notebook.sh
View File

@@ -18,9 +18,5 @@ if [[ "${RESTARTABLE}" == "yes" ]]; then
wrapper="run-one-constantly" wrapper="run-one-constantly"
fi fi
if [[ -v JUPYTER_ENABLE_LAB ]]; then
echo "WARNING: JUPYTER_ENABLE_LAB is ignored, use DOCKER_STACKS_JUPYTER_CMD if you want to change the command used to start the server"
fi
# shellcheck disable=SC1091,SC2086 # shellcheck disable=SC1091,SC2086
exec /usr/local/bin/start.sh ${wrapper} jupyter ${DOCKER_STACKS_JUPYTER_CMD} ${NOTEBOOK_ARGS} "$@" exec /usr/local/bin/start.sh ${wrapper} jupyter ${DOCKER_STACKS_JUPYTER_CMD} ${NOTEBOOK_ARGS} "$@"

6
tests/base-notebook/test_start_container.py
View File

@@ -15,12 +15,6 @@ LOGGER = logging.getLogger(__name__)
@pytest.mark.parametrize( @pytest.mark.parametrize(
"env,expected_command,expected_start,expected_warnings", "env,expected_command,expected_start,expected_warnings",
[ [
(
["JUPYTER_ENABLE_LAB=yes"],
"jupyter lab",
True,
["WARNING: JUPYTER_ENABLE_LAB is ignored"],
),
(None, "jupyter lab", True, []), (None, "jupyter lab", True, []),
(["DOCKER_STACKS_JUPYTER_CMD=lab"], "jupyter lab", True, []), (["DOCKER_STACKS_JUPYTER_CMD=lab"], "jupyter lab", True, []),
(["RESTARTABLE=yes"], "run-one-constantly jupyter lab", True, []), (["RESTARTABLE=yes"], "run-one-constantly jupyter lab", True, []),