76634: Update tests for AppComponent

src/app/app.component.spec.ts

@@ -32,6 +32,7 @@ import { storeModuleConfig } from './app.reducer';
 import { LocaleService } from './core/locale/locale.service';
 import { authReducer } from './core/auth/auth.reducer';
 import { provideMockStore } from '@ngrx/store/testing';
+import {GoogleAnalyticsService} from './statistics/google-analytics.service';
 
 let comp: AppComponent;
 let fixture: ComponentFixture<AppComponent>;
@@ -48,38 +49,40 @@ describe('App component', () => {
     });
   }
 
+  const defaultTestBedConf = {
+    imports: [
+      CommonModule,
+      StoreModule.forRoot(authReducer, storeModuleConfig),
+      TranslateModule.forRoot({
+        loader: {
+          provide: TranslateLoader,
+          useClass: TranslateLoaderMock
+        }
+      }),
+    ],
+    declarations: [AppComponent], // declare the test component
+    providers: [
+      { provide: NativeWindowService, useValue: new NativeWindowRef() },
+      { provide: MetadataService, useValue: new MetadataServiceMock() },
+      { provide: Angulartics2GoogleAnalytics, useValue: new AngularticsProviderMock() },
+      { provide: Angulartics2DSpace, useValue: new AngularticsProviderMock() },
+      { provide: AuthService, useValue: new AuthServiceMock() },
+      { provide: Router, useValue: new RouterMock() },
+      { provide: ActivatedRoute, useValue: new MockActivatedRoute() },
+      { provide: MenuService, useValue: menuService },
+      { provide: CSSVariableService, useClass: CSSVariableServiceStub },
+      { provide: HostWindowService, useValue: new HostWindowServiceStub(800) },
+      { provide: LocaleService, useValue: getMockLocaleService() },
+      provideMockStore({ initialState }),
+      AppComponent,
+      RouteService
+    ],
+    schemas: [CUSTOM_ELEMENTS_SCHEMA]
+  };
+
   // waitForAsync beforeEach
   beforeEach(waitForAsync(() => {
-    return TestBed.configureTestingModule({
-      imports: [
-        CommonModule,
-        StoreModule.forRoot(authReducer, storeModuleConfig),
-        TranslateModule.forRoot({
-          loader: {
-            provide: TranslateLoader,
-            useClass: TranslateLoaderMock
-          }
-        }),
-      ],
-      declarations: [AppComponent], // declare the test component
-      providers: [
-        { provide: NativeWindowService, useValue: new NativeWindowRef() },
-        { provide: MetadataService, useValue: new MetadataServiceMock() },
-        { provide: Angulartics2GoogleAnalytics, useValue: new AngularticsProviderMock() },
-        { provide: Angulartics2DSpace, useValue: new AngularticsProviderMock() },
-        { provide: AuthService, useValue: new AuthServiceMock() },
-        { provide: Router, useValue: new RouterMock() },
-        { provide: ActivatedRoute, useValue: new MockActivatedRoute() },
-        { provide: MenuService, useValue: menuService },
-        { provide: CSSVariableService, useClass: CSSVariableServiceStub },
-        { provide: HostWindowService, useValue: new HostWindowServiceStub(800) },
-        { provide: LocaleService, useValue: getMockLocaleService() },
-        provideMockStore({ initialState }),
-        AppComponent,
-        RouteService
-      ],
-      schemas: [CUSTOM_ELEMENTS_SCHEMA]
-    });
+    return TestBed.configureTestingModule(defaultTestBedConf);
   }));
 
   // synchronous beforeEach
@@ -113,4 +116,31 @@ describe('App component', () => {
     });
 
   });
+
+  describe('when GoogleAnalyticsService is provided', () => {
+    let googleAnalyticsSpy;
+
+    beforeEach(() => {
+      // NOTE: Cannot override providers once components have been compiled, so TestBed needs to be reset
+      TestBed.resetTestingModule();
+      TestBed.configureTestingModule(defaultTestBedConf);
+      googleAnalyticsSpy = jasmine.createSpyObj('googleAnalyticsService', [
+        'addTrackingIdToPage',
+      ]);
+      TestBed.overrideProvider(GoogleAnalyticsService, {useValue: googleAnalyticsSpy});
+      fixture = TestBed.createComponent(AppComponent);
+      comp = fixture.componentInstance;
+      fixture.detectChanges();
+    });
+
+    it('should create component', () => {
+      expect(comp).toBeTruthy();
+    });
+
+    describe('the constructor', () => {
+      it('should call googleAnalyticsService.addTrackingIdToPage()', () => {
+        expect(googleAnalyticsSpy.addTrackingIdToPage).toHaveBeenCalledTimes(1);
+      });
+    });
+  });
 });

src/app/statistics/google-analytics.service.ts

@@ -14,7 +14,7 @@ export class GoogleAnalyticsService {
     @Inject(DOCUMENT) private document: Document
   ) { }
 
-  addTrackingIdToPage() {
+  addTrackingIdToPage(): void {
     this.configService.findByPropertyName('google.analytics.key').pipe(
       getFirstCompletedRemoteData(),
     ).subscribe((remoteData) => {