[CST-4504] Fixed issue for submission, removed tab when editing relationships, removed unused code & improved checking for remote data completed

src/app/item-page/edit-item-page/item-relationships/edit-relationship-list/edit-relationship-list.component.ts

@@ -276,32 +276,6 @@ export class EditRelationshipListComponent implements OnInit, OnDestroy {
       });
 
     this.selectableListService.deselectAll(this.listId);
-    this.updates$.pipe(
-      switchMap((updates) =>
-        Object.values(updates).length > 0 ?
-          observableCombineLatest(
-            Object.values(updates)
-              .filter((update) => update.changeType !== FieldChangeType.REMOVE)
-              .map((update) => {
-                const field = update.field as RelationshipIdentifiable;
-                if (field.relationship) {
-                  return this.getRelatedItem(field.relationship);
-                } else {
-                  return observableOf(field.relatedItem);
-                }
-              })
-          ) : observableOf([])
-      ),
-      take(1),
-      map((items) => items.map((item) => {
-        const searchResult = new ItemSearchResult();
-        searchResult.indexableObject = item;
-        searchResult.hitHighlights = {};
-        return searchResult;
-      })),
-    ).subscribe((items) => {
-      // this.selectableListService.select(this.listId, items);
-    });
   }
 
   /**

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.html

@@ -44,7 +44,7 @@
                 </ds-dynamic-lookup-relation-external-source-tab>
             </ng-template>
         </ngb-tab>
-        <ngb-tab [disabled]="isEditRelationship" [title]="'submission.sections.describe.relationship-lookup.selection-tab.tab-title' | translate : {count: (selection$ | async)?.length}">
+        <ngb-tab *ngIf="!isEditRelationship" [title]="'submission.sections.describe.relationship-lookup.selection-tab.tab-title' | translate : {count: (selection$ | async)?.length}">
             <ng-template ngbTabContent>
                 <ds-dynamic-lookup-relation-selection-tab
                         [selection$]="selection$"

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.ts

@@ -154,9 +154,11 @@ export class DsDynamicLookupRelationModalComponent implements OnInit, OnDestroy
 
   ngOnInit(): void {
 
-    this.currentItemIsLeftItem$.subscribe((isLeft) => {
-      this.isLeft = isLeft;
-    });
+    if(!!this.currentItemIsLeftItem$){
+      this.currentItemIsLeftItem$.subscribe((isLeft) => {
+        this.isLeft = isLeft;
+      });
+    }
 
 
     this.selection$ = this.selectableListService

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/search-tab/dynamic-lookup-relation-search-tab.component.ts

@@ -167,7 +167,7 @@ export class DsDynamicLookupRelationSearchTabComponent implements OnInit, OnDest
       switchMap((options) => this.lookupRelationService.getLocalResults(this.relationship, options).pipe(
         startWith(undefined),
         tap( res => {
-          if ( !!res && res.state === 'Success' && this.isEditRelationship ) {
+          if ( !!res && res.hasSucceeded && this.isEditRelationship ) {
             const idOfItems = res.payload.page.map( itemSearchResult => {
               return itemSearchResult.indexableObject.uuid;
             });