[CST-4504] code improvement and report fixes

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.html

@@ -62,7 +62,8 @@
 </div>
 <div class="modal-footer">
     <small>{{ ('submission.sections.describe.relationship-lookup.selected' | translate: {size: (selection$ | async)?.length || 0}) }}</small>
-    <div>
+    <div class="buttons-container">
+    <div class="close-button">
         <button type="button" class="btn btn-danger" (click)="close()">{{ ('submission.sections.describe.relationship-lookup.close' | translate) }}</button>
     </div>
      <div *ngIf="isEditRelationship" class="button-row bottom">
@@ -85,4 +86,5 @@
           </button>
         </div>
       </div>
+    </div>
 </div>

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.scss

@@ -9,3 +9,10 @@
     margin: 5%;
   }
 }
+
+.buttons-container{
+  display: flex;
+  .close-button{
+    margin-right: 5px;
+  }
+}

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.ts

@@ -135,15 +135,31 @@ export class DsDynamicLookupRelationModalComponent implements OnInit, OnDestroy
    */
   isEditRelationship = false;
 
-  hasChanges;
 
-  isReinstatable;
+  /**
+   * Observable to check if any change has been made
+   */
+  hasChanges: Observable<boolean>;
 
-  submit;
+  /**
+   * Observable to check if any discard has been made
+   */
+  isReinstatable: Observable<boolean>;
 
-  reinstate;
+  /**
+   * Submit event emiter to emit to parent
+   */
+  submit: EventEmitter<any>;
 
-  discard;
+  /**
+   * Reinstate event emiter to emit to parent
+   */
+  reinstate: EventEmitter<any>;
+
+  /**
+   * Discard event emiter to emit to parent
+   */
+  discard: EventEmitter<any>;
 
 
   constructor(