Commit Graph

6509 Commits

Author SHA1 Message Date
Yura Bondarenko
0115c5217b 87968: Turn off preserveWhitespaces by default
And set to true explicitly for MyDSpace action components to preserve look
(see https://github.com/DSpace/dspace-angular/issues/903#issuecomment-713013310)
2022-04-08 17:57:16 +02:00
Yura Bondarenko
a14cc6fde2 87968: Run CI ESLint in --quiet mode 2022-04-08 17:57:16 +02:00
Yura Bondarenko
22ac66787a 87968: Kill app if still up after e2e tests 2022-04-08 17:57:16 +02:00
Yura Bondarenko
99c41b9e80 87968: Minor code changes to pass lint 2022-04-08 17:57:16 +02:00
Yura Bondarenko
bb51609af9 87968: Update ESLint disable/enable comments
eslint-disable max-classes-per-file only works at the top of the file now
2022-04-08 17:57:16 +02:00
Yura Bondarenko
b5911b8536 87968: Manual ESLint configuration
Extend recommended ESLint rulesets, disable rules that are too noisy or would require major code changes to resolve errors
Restore TSLint configuration as closely as possible
2022-04-08 17:57:16 +02:00
Yura Bondarenko
245977a432 87968: Automatic migration from TSLint to ESLint
Via `ng g @angular-eslint/schematics:convert-tslint-to-eslint`
2022-04-08 17:57:16 +02:00
Yura Bondarenko
ec6327edc2 87968: Automatic ESLint install
Via CLI suggestion when running `ng lint` w/o ESLint on Angular 13
2022-04-08 17:57:16 +02:00
Yura Bondarenko
cad76ff378 87968: Increase Node --max_old_space_size 2022-04-08 17:57:16 +02:00
Yura Bondarenko
59d46ffbdf 87968: Upgrade ng-bootstrap to v11
Some tests involving NgbModal now fail if setup with mock Injector without `get` method
2022-04-08 17:57:16 +02:00
Yura Bondarenko
5488d0f83a 87968: Remove unused import 2022-04-08 17:57:16 +02:00
Yura Bondarenko
48efccb53b 87968: Upgrade ngx-gallery 2022-04-08 17:57:16 +02:00
Yura Bondarenko
bfdda43a48 87968: Update devServer configuration 2022-04-08 17:57:16 +02:00
Yura Bondarenko
d78019cd39 87968: Fix unit tests 2022-04-08 17:57:15 +02:00
Yura Bondarenko
563956c5df 87968: Manual fixes after NgRx migration
Selector typing

Restored pre-13 behaviour where mock stores were reset after every test.
The upgrade caused multiple tests to start failing; we could solve this
by adjusting all of these one by one but that would take some time.
(see https://ngrx.io/guide/migration/v13#testing-reset-mock-store)
2022-04-08 17:57:15 +02:00
Yura Bondarenko
8e4f1993bf 87968: Automatic upgrade to NgRx 13 2022-04-08 17:57:15 +02:00
Yura Bondarenko
8f7389c83a 87968: Fix JSON5 parsing in Universal loader
Failed ~
  Error: export 'parse' (imported as 'JSON5') was not found in 'json5' (possible exports: default)

Only affected SSR: once CSR kicked in translations were loaded properly
2022-04-08 17:57:15 +02:00
Yura Bondarenko
49f470c07b 87968: Various dependency changes
Upgraded:
  zone.js
  ng-mocks
  @angular/cdk
  @ngtools/webpack
  @angular-builders/custom-webpack
  @nguniversal

Added:
 postcss-preset-env: fix spurious CSS warnings
 sass-loader: fix "can't resolve 'sass-loader'" & "the loader didn't return a string" errors
2022-04-08 17:57:15 +02:00
Yura Bondarenko
c1d870c32d 87968: Clean up after automatic upgrade
- Get rid of missed empty routerLinks
- Fix abstract property initializers
- Specify coverage reporter
2022-04-08 17:57:15 +02:00
Yura Bondarenko
1b460fe1d3 87968: Automatic upgrade to Angular 13 2022-04-08 17:57:15 +02:00
Yura Bondarenko
47c8ca7342 87968: Lift readyState complete check from Universal 12 2022-04-08 17:57:15 +02:00
Yura Bondarenko
ae89571519 87968: Fix unit tests 2022-04-08 17:57:15 +02:00
Yura Bondarenko
26d45fd5e7 87968: Remove angular2-text-mask dependency 2022-04-08 17:57:15 +02:00
Yura Bondarenko
3eb3afcc96 87968: Fix rxjs/internal imports 2022-04-08 17:57:15 +02:00
Yura Bondarenko
5476062648 87968: Add unmet peer dependencies 2022-04-08 17:57:15 +02:00
Yura Bondarenko
0e178ce1bc 87968: Fix missing theme assets
Adapt to changes in https://github.com/webpack-contrib/copy-webpack-plugin
2022-04-08 17:57:15 +02:00
Art Lowel
808d4e925a Enable source maps in dev mode 2022-04-08 17:57:15 +02:00
Art Lowel
a47d7dd846 Upgrade ng-dynamic forms 2022-04-08 17:57:15 +02:00
Yura Bondarenko
621a874b29 87968: Include theme modules in tsconfig.spec.ts
Without this, Webpack errors out when building tests due to theme components missing from the TS compilation
2022-04-08 17:57:15 +02:00
Yura Bondarenko
9093ef4ae9 87968: Karma needs ts-node 10.2.1
Otherwise tests error out with
  Uncaught ReferenceError: sourceMapSupport is not defined

Check just-jeb/angular-builders issue 1046 for more info
2022-04-08 17:57:15 +02:00
Yura Bondarenko
29d8dd68f4 87968: Remove html-webpack-plugin
After updating to Angular 12, it causes ng serve to fail with
  Conflict: Multiple assets emit different content to the same filename index.html

Confirmed that the application still builds and runs properly without it.

This plugin isn't used by @angular-builders/custom-webpack since Angular 8 (see https://www.justjeb.com/post/customizing-angular-cli-build#viewer-51npg), this is just the first time it's actually causing problems for us.

Removed script-ext-html-webpack-plugin as well since that's an extension to html-webpack-plugin & can't run without it.
2022-04-08 17:57:15 +02:00
Yura Bondarenko
22c5976095 87968: Upgrade to Angular 12 2022-04-08 17:57:15 +02:00
Tim Donohue
45887154b6 Merge pull request #1582 from louiserumpf/translation-de
Updated German translation
2022-04-06 12:08:28 -05:00
Tim Donohue
8a6fd925b4 Merge pull request #1580 from BibNumUMontreal/main
French translation reviewed and updated
2022-04-05 13:51:18 -05:00
Marie-Hélène Vézina
41eebbe661 quick changes to fr.json5
changes according to review : https://github.com/DSpace/dspace-angular/pull/1580#pullrequestreview-930932091
2022-04-04 17:38:20 -04:00
Tim Donohue
9c0fce3a7a Merge pull request #1552 from 4Science/CST-5449
[CST-5449] "Browse by" pages are missing "Now showing" contextual information
2022-04-04 10:07:35 -05:00
Tim Donohue
c1e6976502 Merge pull request #1574 from ybnd/Fix-search-filter-date-range-slider-collapse-animation
Pad date range sliders to fix search facet animation issues
2022-04-01 16:47:28 -05:00
Yura Bondarenko
dac852481e Pad date range sliders
So handles don't jut out when set to the min/max
2022-03-31 21:39:56 +02:00
Giuseppe Digilio
2ce744280b [CST-5449] Fix issue with double result list in the browse page 2022-03-31 19:00:44 +02:00
Giuseppe Digilio
2830f208ce Merge remote-tracking branch 'origin/main' into CST-5449 2022-03-31 16:46:06 +02:00
Tim Donohue
eb7713a702 Merge pull request #1577 from atmire/w2p-88820_Private-Public-Terminology
Changed the public/private terminology
2022-03-30 12:27:23 -05:00
louiserumpf
72885d896f Updated German translation
also corrected comment search.search-form.placeholder --> home.search-form.placeholder
2022-03-27 17:38:47 +02:00
Tim Donohue
e75cb5f64a Merge pull request #1581 from tdonohue/enable_bengali
Enable Bengali by default
2022-03-25 16:33:42 -05:00
Tim Donohue
c4a0bbdf1f Enable Bengali by default 2022-03-25 15:04:57 -05:00
Tim Donohue
bb57992d63 Merge pull request #1573 from raihantopu/main
Adding bn.json5 for 'Bengali Language Transalation'
2022-03-25 15:04:01 -05:00
Tim Donohue
50accfffb0 Merge pull request #1564 from atmire/w2p-88507_Fix-Download-Link-Edit-Bitstream-Page
Fix embargoed files download link not working on edit item page
2022-03-25 14:15:02 -05:00
Marie-Hélène Vézina
75bdf3de79 French translation reviewed and updated
French translation reviewed and updated

These are the main changes:

I have :

- added missing translations (more than ~300 variables)
- corrected the content of a few variables (partial translation and/or wrong translation or translation that deviated from the original); fixed a few typos (e.g. connexion instead of connection for "login")
- standardized the use of « some text » instead of "some text"
- standardized the spacing (among others : one blank before "?", ":", "!" (better yet would be to use a non-breaking space)
- removed the erroneous use of capital letters (e.g. "La Collections et la Communauté" => "La collection et la communauté")
- standardized the verb tenses for some variables (infinitive instead of imperative)
- added articles where they were missing (e.g. "Supprimer groupe" => "Supprimer le groupe")
- removed/corrected tupples : item.page.edit and sorting.lastModified.ASC

For information : I have kept the terms "Item", "Bundle", "Bitstream", "Eperson", "Workflow" (but I made sure that those words were capitalized to show they represent specific concepts) [In our local instance however, we localised the first three ones to, respectively, "document", "groupement", "fichier" in this order]

Still to do:

- gender-inclusive writing (e.g. : "utilisateur.trice", "auteur.e" or more generic forms)
2022-03-25 14:30:58 -04:00
Tim Donohue
adbad6907d Merge pull request #1556 from atmire/w2p-88248_Withdrawn-item-tombstone
Withdrawn item tombstone
2022-03-25 10:03:53 -05:00
Tim Donohue
25133935ef Merge pull request #1572 from louiserumpf/main
updated German translation
2022-03-24 16:58:42 -05:00
Jens Vannerum
ceec5661fe 88820: Changed the public/private terminology
- Changed the terminology to use discoverable / non-discoverable as this is more clear and is suitable in every context
2022-03-24 15:43:04 +01:00